Whenever we do an strncpy we should make sure we put a '\0' at the end

of the buffer.

Whenever we do an strncpy we should make sure we put a '\0' at the end
42d4f301 · Francois Gouget · Alexandre Julliard · f4077e66 · 42d4f301
Commit 42d4f301 authored Dec 05, 1999 by Francois Gouget Committed by Alexandre Julliard Dec 05, 1999
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

listview.c dlls/comctl32/listview.c +4 -0

No files found.
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -3609,10 +3609,12 @@ static LRESULT LISTVIEW_GetItemA(HWND hwnd, LPLVITEMA lpLVItem)
                Str_SetPtrA(&lpItem->pszText, dispInfo.item.pszText);
              }
              strncpy(lpLVItem->pszText, dispInfo.item.pszText, lpLVItem->cchTextMax);
+              lpLVItem->pszText[lpLVItem->cchTextMax-1]='\0';
            }
            else if (lpLVItem->mask & LVIF_TEXT)
            {
              strncpy(lpLVItem->pszText, lpItem->pszText, lpLVItem->cchTextMax);
+              lpLVItem->pszText[lpLVItem->cchTextMax-1]='\0';
            }
            if (dispInfo.item.mask & LVIF_STATE)
@@ -3704,10 +3706,12 @@ static LRESULT LISTVIEW_GetItemA(HWND hwnd, LPLVITEMA lpLVItem)
                  Str_SetPtrA(&lpSubItem->pszText, dispInfo.item.pszText);
              }
              strncpy(lpLVItem->pszText, dispInfo.item.pszText, lpLVItem->cchTextMax);
+              lpLVItem->pszText[lpLVItem->cchTextMax-1]='\0';
            }
            else if (lpLVItem->mask & LVIF_TEXT)
            {
              strncpy(lpLVItem->pszText, lpSubItem->pszText, lpLVItem->cchTextMax);
+              lpLVItem->pszText[lpLVItem->cchTextMax-1]='\0';
            }
          }
        }