comctl32/treeview: Don't repaint when handling WM_STYLECHANGED.

Some applications subclass treeview and change style multiple times when painting. Invalidating control when handling WM_STYLECHANGED causes infinite WM_PAINT messages in this case and end up stalling the message queue.

comctl32/treeview: Don't repaint when handling WM_STYLECHANGED.
44cfa3ec · Zhiyi Zhang · Alexandre Julliard · c8ec431f · 44cfa3ec · 44cfa3ec
Commit 44cfa3ec authored Oct 17, 2022 by Zhiyi Zhang Committed by Alexandre Julliard Oct 18, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

misc.c dlls/comctl32/tests/misc.c +1 -1

treeview.c dlls/comctl32/treeview.c +0 -1

No files found.
--- a/dlls/comctl32/tests/misc.c
+++ b/dlls/comctl32/tests/misc.c
@@ -1109,7 +1109,7 @@ static void test_WM_STYLECHANGED(void)
        {TOOLBARCLASSNAMEA, wm_stylechanged_seq},
        {TOOLTIPS_CLASSA, wm_stylechanged_seq},
        {TRACKBAR_CLASSA, wm_stylechanged_trackbar_seq, TRUE},
-        {WC_TREEVIEWA, wm_stylechanged_seq, TRUE},
+        {WC_TREEVIEWA, wm_stylechanged_seq},
        {UPDOWN_CLASSA, wm_stylechanged_seq, TRUE},
        {WC_SCROLLBARA, wm_stylechanged_seq},
    };

--- a/dlls/comctl32/treeview.c
+++ b/dlls/comctl32/treeview.c
@@ -5627,7 +5627,6 @@ TREEVIEW_StyleChanged(TREEVIEW_INFO *infoPtr, WPARAM wParam, LPARAM lParam)
    TREEVIEW_EndEditLabelNow(infoPtr, TRUE);
    TREEVIEW_UpdateSubTree(infoPtr, infoPtr->root);
    TREEVIEW_UpdateScrollBars(infoPtr);
-    TREEVIEW_Invalidate(infoPtr, NULL);

    return 0;
 }