dmsynth: Don't store a SynthSink implementation in IDirectMusicSynth8Impl.

Avoids an unsafe interface to object transition. Signed-off-by: Michael Stefaniuc <mstefani@winehq.org> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dmsynth: Don't store a SynthSink implementation in IDirectMusicSynth8Impl.
44fd37a3 · Michael Stefaniuc · Alexandre Julliard · a6a9ec44 · 44fd37a3 · 44fd37a3
Commit 44fd37a3 authored Apr 05, 2017 by Michael Stefaniuc Committed by Alexandre Julliard Apr 05, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

dmsynth_private.h dlls/dmsynth/dmsynth_private.h +1 -1

synth.c dlls/dmsynth/synth.c +2 -2

No files found.
--- a/dlls/dmsynth/dmsynth_private.h
+++ b/dlls/dmsynth/dmsynth_private.h
@@ -66,7 +66,7 @@ struct IDirectMusicSynth8Impl {
    DMUS_PORTCAPS pCaps;
    BOOL fActive;
    IReferenceClock* pLatencyClock;
-    IDirectMusicSynthSinkImpl* pSynthSink;
+    IDirectMusicSynthSink *synth_sink;
 };

 /*****************************************************************************

--- a/dlls/dmsynth/synth.c
+++ b/dlls/dmsynth/synth.c
@@ -310,7 +310,7 @@ static HRESULT WINAPI IDirectMusicSynth8Impl_GetLatencyClock(LPDIRECTMUSICSYNTH8
    if (!clock)
        return E_POINTER;

-    if (!This->pSynthSink)
+    if (!This->synth_sink)
        return DMUS_E_NOSYNTHSINK;

    *clock = This->pLatencyClock;
@@ -336,7 +336,7 @@ static HRESULT WINAPI IDirectMusicSynth8Impl_SetSynthSink(LPDIRECTMUSICSYNTH8 if

    TRACE("(%p)->(%p)\n", iface, synth_sink);

-    This->pSynthSink = (IDirectMusicSynthSinkImpl*)synth_sink;
+    This->synth_sink = synth_sink;

    if (synth_sink)
        return IDirectMusicSynthSink_GetLatencyClock(synth_sink, &This->pLatencyClock);