ieframe: Fix moniker leak on error path.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ieframe: Fix moniker leak on error path.
477e7fdf · Nikolay Sivov · Alexandre Julliard · eaef858b · 477e7fdf
Commit 477e7fdf authored Nov 10, 2016 by Nikolay Sivov Committed by Alexandre Julliard Nov 14, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

navigate.c dlls/ieframe/navigate.c +4 -1

No files found.
--- a/dlls/ieframe/navigate.c
+++ b/dlls/ieframe/navigate.c
@@ -703,13 +703,16 @@ static HRESULT bind_to_object(DocHost *This, IMoniker *mon, LPCWSTR url, IBindCt
    hres = IMoniker_GetDisplayName(mon, 0, NULL, &display_name);
    if(FAILED(hres)) {
        FIXME("GetDisplayName failed: %08x\n", hres);
+        IMoniker_Release(mon);
        return hres;
    }

    hres = set_dochost_url(This, display_name);
    CoTaskMemFree(display_name);
-    if(FAILED(hres))
+    if(FAILED(hres)) {
+        IMoniker_Release(mon);
        return hres;
+    }

    IBindCtx_RegisterObjectParam(bindctx, (LPOLESTR)SZ_HTML_CLIENTSITE_OBJECTPARAM,
                                 (IUnknown*)&This->IOleClientSite_iface);