quartz/tests: Fix potential NULL dereference (Coverity).

48865c90 · Alexander Dorofeyev · Alexandre Julliard · 67684c48 · 48865c90
Commit 48865c90 authored Sep 09, 2008 by Alexander Dorofeyev Committed by Alexandre Julliard Sep 10, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

filtergraph.c dlls/quartz/tests/filtergraph.c +5 -2

No files found.
--- a/dlls/quartz/tests/filtergraph.c
+++ b/dlls/quartz/tests/filtergraph.c
@@ -1122,9 +1122,12 @@ static HRESULT TestFilter_Create(const CLSID* pClsid, const TestFilterPinData *p

    error:

-    for (i = 0; i < nPins; i++)
+    if (pTestFilter->ppPins)
    {
-        if (pTestFilter->ppPins[i]) IPin_Release(pTestFilter->ppPins[i]);
+        for (i = 0; i < nPins; i++)
+        {
+            if (pTestFilter->ppPins[i]) IPin_Release(pTestFilter->ppPins[i]);
+        }
    }
    CoTaskMemFree(pTestFilter->ppPins);
    DeleteCriticalSection(&pTestFilter->csFilter);