oleaut32: Add missing return value checks (Coverity).

CID 1442938: Error handling issues (CHECKED_RETURN) Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

oleaut32: Add missing return value checks (Coverity).
4a6f002d · Alistair Leslie-Hughes · Alexandre Julliard · 1866fd65 · 4a6f002d
Commit 4a6f002d authored Mar 03, 2019 by Alistair Leslie-Hughes Committed by Alexandre Julliard Mar 04, 2019
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

variant.c dlls/oleaut32/variant.c +4 -2

No files found.
--- a/dlls/oleaut32/variant.c
+++ b/dlls/oleaut32/variant.c
@@ -5138,7 +5138,9 @@ HRESULT WINAPI VarRound(LPVARIANT pVarIn, int deci, LPVARIANT pVarOut)
    {
        double dbl;

-        VarR8FromDec(&V_DECIMAL(pVarIn), &dbl);
+        hRet = VarR8FromDec(&V_DECIMAL(pVarIn), &dbl);
+        if (FAILED(hRet))
+            break;

        if (dbl>0.0f)
            dbl = floor(dbl*pow(10,deci)+0.5);
@@ -5146,7 +5148,7 @@ HRESULT WINAPI VarRound(LPVARIANT pVarIn, int deci, LPVARIANT pVarOut)
            dbl = ceil(dbl*pow(10,deci)-0.5);

        V_VT(pVarOut)=VT_DECIMAL;
-        VarDecFromR8(dbl, &V_DECIMAL(pVarOut));
+        hRet = VarDecFromR8(dbl, &V_DECIMAL(pVarOut));
        break;
    }
    /* cases we don't know yet */