dmusic: Stop leaking instruments on collection release.

4ae866a0 · Rémi Bernon · Alexandre Julliard · 572125ed · 4ae866a0
Commit 4ae866a0 authored Sep 09, 2023 by Rémi Bernon Committed by Alexandre Julliard Sep 11, 2023
Show whitespace changes
Inline Side-by-side

Showing with 12 additions and 1 deletion

collection.c dlls/dmusic/collection.c +12 -1

No files found.
--- a/dlls/dmusic/collection.c
+++ b/dlls/dmusic/collection.c
@@ -98,7 +98,18 @@ static ULONG WINAPI collection_Release(IDirectMusicCollection *iface)

    TRACE("(%p): new ref = %lu\n", iface, ref);

-    if (!ref) {
+    if (!ref)
+    {
+        struct instrument_entry *instrument_entry;
+        void *next;
+
+        LIST_FOR_EACH_ENTRY_SAFE(instrument_entry, next, &This->instruments, struct instrument_entry, entry)
+        {
+            list_remove(&instrument_entry->entry);
+            IDirectMusicInstrument_Release(instrument_entry->instrument);
+            free(instrument_entry);
+        }
+
        free(This);
    }