quartz/vmr9: Avoid leaking the surface array on connection failure.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

quartz/vmr9: Avoid leaking the surface array on connection failure.
4eb58312 · Zebediah Figura · Alexandre Julliard · c4f92087 · 4eb58312
Commit 4eb58312 authored Jun 19, 2020 by Zebediah Figura Committed by Alexandre Julliard Jun 20, 2020
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

vmr9.c dlls/quartz/vmr9.c +5 -1

No files found.
--- a/dlls/quartz/vmr9.c
+++ b/dlls/quartz/vmr9.c
@@ -428,11 +428,14 @@ static HRESULT allocate_surfaces(struct quartz_vmr *filter, const AM_MEDIA_TYPE 
            case 32: info.Format = D3DFMT_X8R8G8B8; break;
            default:
                FIXME("Unhandled bit depth %u.\n", filter->bmiheader.biBitCount);
+                free(filter->surfaces);
                return E_INVALIDARG;
        }

        info.dwFlags = VMR9AllocFlag_TextureSurface;
-        return initialize_device(filter, &info, count);
+        if (FAILED(hr = initialize_device(filter, &info, count)))
+            free(filter->surfaces);
+        return hr;
    }

    for (i = 0; i < ARRAY_SIZE(formats); ++i)
@@ -457,6 +460,7 @@ static HRESULT allocate_surfaces(struct quartz_vmr *filter, const AM_MEDIA_TYPE 
        }
    }

+    free(filter->surfaces);
    return hr;
 }