Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
4ee173df
Commit
4ee173df
authored
Dec 18, 2018
by
Dmitry Timoshkov
Committed by
Alexandre Julliard
Dec 18, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
comctl32: Don't ignore page creation error for a non-modal propery sheet.
Signed-off-by:
Dmitry Timoshkov
<
dmitry@baikal.ru
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
ca41fd89
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
8 deletions
+8
-8
propsheet.c
dlls/comctl32/propsheet.c
+8
-4
propsheet.c
dlls/comctl32/tests/propsheet.c
+0
-4
No files found.
dlls/comctl32/propsheet.c
View file @
4ee173df
...
...
@@ -2012,6 +2012,13 @@ static BOOL PROPSHEET_SetCurSel(HWND hwndDlg,
if
(
!
psInfo
->
proppage
[
index
].
hwndPage
)
{
if
(
!
PROPSHEET_CreatePage
(
hwndDlg
,
index
,
psInfo
,
ppshpage
))
{
PROPSHEET_RemovePage
(
hwndDlg
,
index
,
NULL
);
if
(
!
psInfo
->
isModeless
)
{
DestroyWindow
(
hwndDlg
);
return
FALSE
;
}
if
(
index
>=
psInfo
->
nPages
)
index
--
;
if
(
index
<
0
)
...
...
@@ -2754,7 +2761,7 @@ static void PROPSHEET_CleanUp(HWND hwndDlg)
static
INT
do_loop
(
const
PropSheetInfo
*
psInfo
)
{
MSG
msg
;
INT
ret
=
-
1
;
INT
ret
=
0
;
HWND
hwnd
=
psInfo
->
hwnd
;
HWND
parent
=
psInfo
->
ppshheader
.
hwndParent
;
...
...
@@ -2771,10 +2778,7 @@ static INT do_loop(const PropSheetInfo *psInfo)
}
if
(
ret
==
0
)
{
PostQuitMessage
(
msg
.
wParam
);
ret
=
-
1
;
}
if
(
ret
!=
-
1
)
ret
=
psInfo
->
result
;
...
...
dlls/comctl32/tests/propsheet.c
View file @
4ee173df
...
...
@@ -276,7 +276,6 @@ static void test_disableowner(void)
psh
.
pfnCallback
=
disableowner_callback
;
p
=
pPropertySheetA
(
&
psh
);
todo_wine
ok
(
p
==
0
,
"Expected 0, got %ld
\n
"
,
p
);
ok
(
IsWindowEnabled
(
parenthwnd
)
!=
0
,
"parent window should be enabled
\n
"
);
DestroyWindow
(
parenthwnd
);
...
...
@@ -1165,11 +1164,8 @@ static void test_bad_control_class(void)
psh
.
hwndParent
=
GetDesktopWindow
();
U3
(
psh
).
phpage
=
&
hpsp
;
if
(
!
strcmp
(
winetest_platform
,
"windows"
))
/* FIXME: enable once Wine is fixed */
{
ret
=
pPropertySheetA
(
&
psh
);
ok
(
ret
==
0
,
"got %ld
\n
"
,
ret
);
}
/* Need to recreate hpsp otherwise the test fails under Windows */
hpsp
=
pCreatePropertySheetPageA
(
&
psp
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment