comdlg32: Avoid possible NULL pointer dereference (Coverity).

4ff3d995 · Kai Blin · Alexandre Julliard · 4dceb1f8 · 4ff3d995
Commit 4ff3d995 authored Oct 14, 2008 by Kai Blin Committed by Alexandre Julliard Oct 15, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

filedlg31.c dlls/comdlg32/filedlg31.c +4 -2

No files found.
--- a/dlls/comdlg32/filedlg31.c
+++ b/dlls/comdlg32/filedlg31.c
@@ -312,8 +312,10 @@ static void FD31_UpdateResult(const FD31_DATA *lfs, const WCHAR *tmpstr)
    if (lenstr2 > 3)
        tmpstr2[lenstr2++]='\\';
    lstrcpynW(tmpstr2+lenstr2, tmpstr, BUFFILE-lenstr2);
-    if (ofnW->lpstrFile)
+    if (!ofnW->lpstrFile)
-        lstrcpynW(ofnW->lpstrFile, tmpstr2, ofnW->nMaxFile);
+        return;
+    lstrcpynW(ofnW->lpstrFile, tmpstr2, ofnW->nMaxFile);
    /* set filename offset */
    p = PathFindFileNameW(ofnW->lpstrFile);