hidclass.sys: Overwrite queued reports as FIFO instead of LIFO.

Based on a patch from Ivo Ivanov <logos128@gmail.com>. The issue causes severe skipping and non smooth movement tracking in apps/games, when the HidP/HidD APIs are used to control the device (joysticks, controllers, steering wheels, etc.). Usually such devices use constant stream of INPUT reports to report their coords, so any report skipping or change of the sequence, when the interested apps are reading, would lead to such issues. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51824Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

hidclass.sys: Overwrite queued reports as FIFO instead of LIFO.
51ae9262 · Rémi Bernon · Alexandre Julliard · 9411ecf6 · 51ae9262
Commit 51ae9262 authored Oct 04, 2021 by Rémi Bernon Committed by Alexandre Julliard Oct 04, 2021
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

device.c dlls/hidclass.sys/device.c +3 -1

No files found.
--- a/dlls/hidclass.sys/device.c
+++ b/dlls/hidclass.sys/device.c
@@ -190,10 +190,12 @@ static void hid_queue_push_report( struct hid_queue *queue, struct hid_report *r
    KeAcquireSpinLock( &queue->lock, &irql );
    prev = queue->reports[i];
    queue->reports[i] = report;
-    if (next != queue->read_idx) queue->write_idx = next;
+    if (next == queue->read_idx) queue->read_idx = next + 1;
+    if (queue->read_idx >= queue->length) queue->read_idx = 0;
    KeReleaseSpinLock( &queue->lock, irql );

    hid_report_decref( prev );
+    queue->write_idx = next;
 }

 static struct hid_report *hid_queue_pop_report( struct hid_queue *queue )