Commit 51ec927c authored by Lionel Ulmer's avatar Lionel Ulmer Committed by Alexandre Julliard

- fix 'empty' glyphs

- implement proper bitmap coordinates
parent 1a87dc42
...@@ -534,15 +534,12 @@ static BOOL internal_wglUseFontBitmaps(HDC hdc, ...@@ -534,15 +534,12 @@ static BOOL internal_wglUseFontBitmaps(HDC hdc,
int needed_size = GetGlyphOutline_ptr(hdc, glyph, GGO_BITMAP, &gm, 0, NULL, NULL); int needed_size = GetGlyphOutline_ptr(hdc, glyph, GGO_BITMAP, &gm, 0, NULL, NULL);
int height, width_int; int height, width_int;
TRACE("Glyph : %d\n", glyph); TRACE("Glyph : %3d / List : %ld\n", glyph, listBase);
if (needed_size == GDI_ERROR) { if (needed_size == GDI_ERROR) {
TRACE(" - needed size : %d (GDI_ERROR)\n", needed_size); TRACE(" - needed size : %d (GDI_ERROR)\n", needed_size);
goto error; goto error;
} else { } else {
TRACE(" - needed size : %d\n", needed_size); TRACE(" - needed size : %d\n", needed_size);
if (needed_size == 0) {
continue;
}
} }
if (needed_size > size) { if (needed_size > size) {
...@@ -557,12 +554,13 @@ static BOOL internal_wglUseFontBitmaps(HDC hdc, ...@@ -557,12 +554,13 @@ static BOOL internal_wglUseFontBitmaps(HDC hdc,
unsigned int height, width, bitmask; unsigned int height, width, bitmask;
unsigned char *bitmap_ = (unsigned char *) bitmap; unsigned char *bitmap_ = (unsigned char *) bitmap;
DPRINTF(" - bbox : %d x %d\n", gm.gmBlackBoxX, gm.gmBlackBoxY); TRACE(" - bbox : %d x %d\n", gm.gmBlackBoxX, gm.gmBlackBoxY);
DPRINTF(" - origin : (%ld , %ld)\n", gm.gmptGlyphOrigin.x, gm.gmptGlyphOrigin.y); TRACE(" - origin : (%ld , %ld)\n", gm.gmptGlyphOrigin.x, gm.gmptGlyphOrigin.y);
DPRINTF(" - increment : %d - %d\n", gm.gmCellIncX, gm.gmCellIncY); TRACE(" - increment : %d - %d\n", gm.gmCellIncX, gm.gmCellIncY);
DPRINTF(" - bitmap : \n"); if (needed_size != 0) {
TRACE(" - bitmap : \n");
for (height = 0; height < gm.gmBlackBoxY; height++) { for (height = 0; height < gm.gmBlackBoxY; height++) {
DPRINTF(" "); TRACE(" ");
for (width = 0, bitmask = 0x80; width < gm.gmBlackBoxX; width++, bitmask >>= 1) { for (width = 0, bitmask = 0x80; width < gm.gmBlackBoxX; width++, bitmask >>= 1) {
if (bitmask == 0) { if (bitmask == 0) {
bitmap_ += 1; bitmap_ += 1;
...@@ -577,9 +575,12 @@ static BOOL internal_wglUseFontBitmaps(HDC hdc, ...@@ -577,9 +575,12 @@ static BOOL internal_wglUseFontBitmaps(HDC hdc,
DPRINTF("\n"); DPRINTF("\n");
} }
} }
}
/* For some obscure reasons, I seem to need to rotate the glyph for OpenGL to be happy. /* In OpenGL, the bitmap is drawn from the bottom to the top... So we need to invert the
As Wine does not seem to support the MAT2 field, I need to do it myself.... */ * glyph for it to be drawn properly.
*/
if (needed_size != 0) {
width_int = (gm.gmBlackBoxX + 31) / 32; width_int = (gm.gmBlackBoxX + 31) / 32;
for (height = 0; height < gm.gmBlackBoxY; height++) { for (height = 0; height < gm.gmBlackBoxY; height++) {
int width; int width;
...@@ -588,11 +589,19 @@ static BOOL internal_wglUseFontBitmaps(HDC hdc, ...@@ -588,11 +589,19 @@ static BOOL internal_wglUseFontBitmaps(HDC hdc,
((int *) bitmap)[height * width_int + width]; ((int *) bitmap)[height * width_int + width];
} }
} }
}
ENTER_GL(); ENTER_GL();
glNewList(listBase++, GL_COMPILE); glNewList(listBase++, GL_COMPILE);
glBitmap(gm.gmBlackBoxX, gm.gmBlackBoxY, gm.gmptGlyphOrigin.x, if (needed_size != 0) {
gm.gmBlackBoxY - gm.gmptGlyphOrigin.y, gm.gmCellIncX, gm.gmCellIncY, gl_bitmap); glBitmap(gm.gmBlackBoxX, gm.gmBlackBoxY,
0 - gm.gmptGlyphOrigin.x, gm.gmBlackBoxY - gm.gmptGlyphOrigin.y,
gm.gmCellIncX, gm.gmCellIncY,
gl_bitmap);
} else {
/* This is the case of 'empty' glyphs like the space character */
glBitmap(0, 0, 0, 0, gm.gmCellIncX, gm.gmCellIncY, NULL);
}
glEndList(); glEndList();
LEAVE_GL(); LEAVE_GL();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment