user32: Introduce a SCROLL_DrawNCScrollBar() to draw scroll bars in non-client area.

Having a SCROLL_DrawNCScrollBar() in scroll.c enables it to access global variables there. So that global variables access in SCROLL_DrawScrollBar() can be moved outside of it and SCROLL_DrawScrollBar() can then be refactored into a function without access to global variables. Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

user32: Introduce a SCROLL_DrawNCScrollBar() to draw scroll bars in non-client area.
5541cf32 · Zhiyi Zhang · Alexandre Julliard · ac6817de · 5541cf32 · 5541cf32
Commit 5541cf32 authored Jul 05, 2021 by Zhiyi Zhang Committed by Alexandre Julliard Jul 05, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 5 deletions

controls.h dlls/user32/controls.h +1 -0

nonclient.c dlls/user32/nonclient.c +1 -5

scroll.c dlls/user32/scroll.c +8 -0

No files found.
--- a/dlls/user32/controls.h
+++ b/dlls/user32/controls.h
@@ -179,6 +179,7 @@ extern BOOL NC_DrawSysButton( HWND hwnd, HDC hdc, BOOL down ) DECLSPEC_HIDDEN;
 extern void NC_GetSysPopupPos( HWND hwnd, RECT* rect ) DECLSPEC_HIDDEN;

 /* scrollbar */
+extern void SCROLL_DrawNCScrollBar( HWND hwnd, HDC hdc, BOOL draw_horizontal, BOOL draw_vertical ) DECLSPEC_HIDDEN;
 extern void SCROLL_DrawScrollBar( HWND hwnd, HDC hdc, INT nBar, BOOL arrows, BOOL interior ) DECLSPEC_HIDDEN;
 extern void SCROLL_TrackScrollBar( HWND hwnd, INT scrollbar, POINT pt ) DECLSPEC_HIDDEN;


--- a/dlls/user32/nonclient.c
+++ b/dlls/user32/nonclient.c
@@ -1027,11 +1027,7 @@ static void  NC_DoNCPaint( HWND  hwnd, HRGN  clip )
 	DrawEdge (hdc, &rect, EDGE_SUNKEN, BF_RECT | BF_ADJUST);

    /* Draw the scroll-bars */
-
-    if (dwStyle & WS_VSCROLL)
-        SCROLL_DrawScrollBar( hwnd, hdc, SB_VERT, TRUE, TRUE );
-    if (dwStyle & WS_HSCROLL)
-        SCROLL_DrawScrollBar( hwnd, hdc, SB_HORZ, TRUE, TRUE );
+    SCROLL_DrawNCScrollBar( hwnd, hdc, dwStyle & WS_HSCROLL, dwStyle & WS_VSCROLL );

    /* Draw the "size-box" */
    if ((dwStyle & WS_VSCROLL) && (dwStyle & WS_HSCROLL))

--- a/dlls/user32/scroll.c
+++ b/dlls/user32/scroll.c
@@ -646,6 +646,14 @@ void SCROLL_DrawScrollBar( HWND hwnd, HDC hdc, INT nBar,
    }
 }

+void SCROLL_DrawNCScrollBar( HWND hwnd, HDC hdc, BOOL draw_horizontal, BOOL draw_vertical )
+{
+    if (draw_horizontal)
+        SCROLL_DrawScrollBar( hwnd, hdc, SB_HORZ, TRUE, TRUE );
+    if (draw_vertical)
+        SCROLL_DrawScrollBar( hwnd, hdc, SB_VERT, TRUE, TRUE );
+}
+
 /***********************************************************************
 *           SCROLL_DrawSizeGrip
 *