msi: Fix heap overflow in save_string_table.

Fix heap overflow caused by not accounting for the dummy first item, which contains the codepage.

msi: Fix heap overflow in save_string_table.
66c9cbbe · Robert Shearman · Alexandre Julliard · 6c529a72 · 66c9cbbe
Commit 66c9cbbe authored Feb 22, 2006 by Robert Shearman Committed by Alexandre Julliard Feb 22, 2006
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

table.c dlls/msi/table.c +1 -1

No files found.
--- a/dlls/msi/table.c
+++ b/dlls/msi/table.c
@@ -755,7 +755,7 @@ static UINT save_string_table( MSIDATABASE *db )

    /* construct the new table in memory first */
    datasize = msi_string_totalsize( db->strings, &count );
-    poolsize = count*2*sizeof(USHORT);
+    poolsize = (count + 1)*2*sizeof(USHORT);

    pool = msi_alloc( poolsize );
    if( ! pool )