Moved private USER definitions to a new user_private.h header, and

dlls/user/button.c

@@ -73,7 +73,7 @@
 #include "wingdi.h"
 #include "wine/winuser16.h"
 #include "controls.h"
-#include "user.h"
+#include "user_private.h"
 
 /* GetWindowLong offsets for window extra information */
 #define STATE_GWL_OFFSET  0

dlls/user/combo.c

@@ -45,7 +45,6 @@
 #include "wine/winuser16.h"
 #include "wine/unicode.h"
 #include "message.h"
-#include "user.h"
 #include "win.h"
 #include "controls.h"
 #include "winreg.h"

dlls/user/comm16.c

@@ -68,6 +68,7 @@
 #include "winuser.h"
 #include "wine/winuser16.h"
 #include "win.h"
+#include "user_private.h"
 #include "winerror.h"
 
 #include "wine/debug.h"

dlls/user/controls.h

@@ -46,6 +46,9 @@ struct builtin_class_descr
 };
 
 
+/* defwnd proc */
+extern HBRUSH DEFWND_ControlColor( HDC hDC, UINT ctlType );
+
 /* desktop */
 extern BOOL DESKTOP_SetPattern( LPCWSTR pattern );
 
@@ -58,6 +61,7 @@ extern HWND MENU_IsMenuActive(void);
 extern HMENU MENU_GetSysMenu(HWND hWndOwner, HMENU hSysPopup);
 extern UINT MENU_GetMenuBarHeight( HWND hwnd, UINT menubarWidth,
                                      INT orgX, INT orgY );
+extern BOOL MENU_SetMenu(HWND, HMENU);
 extern void MENU_TrackMouseMenuBar( HWND hwnd, INT ht, POINT pt );
 extern void MENU_TrackKbdMenuBar( HWND hwnd, UINT wParam, WCHAR wChar );
 extern UINT MENU_DrawMenuBar( HDC hDC, LPRECT lprect,

dlls/user/desktop.c

@@ -30,7 +30,6 @@
 #include "windef.h"
 #include "winbase.h"
 #include "wingdi.h"
-#include "user.h"
 #include "controls.h"
 #include "wine/winuser16.h"
 

dlls/user/dialog16.c

@@ -29,7 +29,7 @@
 #include "wine/winuser16.h"
 #include "controls.h"
 #include "win.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/debug.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(dialog);

dlls/user/display.c

@@ -23,7 +23,7 @@
 #include "wine/debug.h"
 #include "windef.h"
 #include "winbase.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/winuser16.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(cursor);

dlls/user/edit.c

@@ -71,7 +71,7 @@
 #include "controls.h"
 #include "local.h"
 #include "message.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/debug.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(edit);

dlls/user/focus.c

@@ -31,7 +31,7 @@
 #include "winerror.h"
 #include "win.h"
 #include "message.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/server.h"
 #include "wine/debug.h"
 

dlls/user/hook.c

@@ -73,6 +73,7 @@
 #include "heap.h"
 #include "message.h"
 #include "win.h"
+#include "user_private.h"
 #include "wine/server.h"
 #include "wine/unicode.h"
 #include "wine/debug.h"

dlls/user/hook16.c

@@ -30,6 +30,7 @@
 #include "wine/winuser16.h"
 #include "message.h"
 #include "win.h"
+#include "user_private.h"
 #include "winproc.h"
 #include "wine/debug.h"
 

dlls/user/listbox.c

@@ -48,7 +48,6 @@
 #include "winuser.h"
 #include "winerror.h"
 #include "message.h"
-#include "user.h"
 #include "controls.h"
 #include "wine/debug.h"
 #include "win.h"

dlls/user/menu.c

@@ -44,7 +44,7 @@
 #include "win.h"
 #include "controls.h"
 #include "nonclient.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/debug.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(menu);

dlls/user/message.c

@@ -35,7 +35,7 @@
 #include "wine/unicode.h"
 #include "wine/server.h"
 #include "message.h"
-#include "user.h"
+#include "user_private.h"
 #include "win.h"
 #include "winproc.h"
 #include "wine/debug.h"

dlls/user/message.h

@@ -88,4 +88,10 @@ extern void SPY_ExitMessage( INT iFlag, HWND hwnd, UINT msg,
                              LRESULT lReturn, WPARAM wParam, LPARAM lParam );
 extern int SPY_Init(void);
 
+/* check if hwnd is a broadcast magic handle */
+inline static BOOL is_broadcast( HWND hwnd )
+{
+    return (hwnd == HWND_BROADCAST || hwnd == HWND_TOPMOST);
+}
+
 #endif  /* __WINE_MESSAGE_H */

dlls/user/msg16.c

@@ -23,6 +23,7 @@
 #include "winerror.h"
 #include "message.h"
 #include "win.h"
+#include "user_private.h"
 #include "winproc.h"
 #include "wine/debug.h"
 

dlls/user/resource.c

@@ -28,7 +28,6 @@
 #include "wine/winbase16.h"
 #include "wine/winuser16.h"
 #include "wownt32.h"
-#include "user.h"
 #include "wine/debug.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(resource);

dlls/user/scroll.c

@@ -42,7 +42,7 @@
 #include "controls.h"
 #include "win.h"
 #include "wine/debug.h"
-#include "user.h"
+#include "user_private.h"
 #include "message.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(scroll);

dlls/user/static.c

@@ -56,7 +56,7 @@
 #include "wownt32.h"
 #include "cursoricon.h"
 #include "controls.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/debug.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(static);

dlls/user/text.c

@@ -39,7 +39,6 @@
 #include "winerror.h"
 #include "winnls.h"
 #include "wownt32.h"
-#include "user.h"
 #include "controls.h"
 #include "wine/debug.h"
 

dlls/user/uitools.c

@@ -26,7 +26,7 @@
 #include "wingdi.h"
 #include "wine/winuser16.h"
 #include "winuser.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/unicode.h"
 #include "wine/debug.h"
 

dlls/user/user16.c

@@ -24,7 +24,7 @@
 #include "windef.h"
 #include "winbase.h"
 #include "wownt32.h"
-#include "user.h"
+#include "user_private.h"
 #include "win.h"
 #include "winproc.h"
 #include "cursoricon.h"

dlls/user/user_main.c

@@ -31,7 +31,7 @@
 #include "controls.h"
 #include "cursoricon.h"
 #include "message.h"
-#include "user.h"
+#include "user_private.h"
 #include "win.h"
 #include "wine/debug.h"
 

include/user.h → dlls/user/user_private.h

 /*
- * USER definitions
+ * USER private definitions
  *
  * Copyright 1993 Alexandre Julliard
  *
@@ -18,16 +18,15 @@
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
-#ifndef __WINE_USER_H
-#define __WINE_USER_H
+#ifndef __WINE_USER_PRIVATE_H
+#define __WINE_USER_PRIVATE_H
 
 #include <stdarg.h>
-#include <windef.h>
-#include <winbase.h>
-#include <wingdi.h>
-#include <winuser.h>
-
-#include <local.h>
+#include "windef.h"
+#include "winbase.h"
+#include "wingdi.h"
+#include "winuser.h"
+#include "local.h"
 
 extern WORD USER_HeapSel;
 
@@ -43,14 +42,6 @@ extern WORD USER_HeapSel;
 #define GET_WORD(ptr)  (*(const WORD *)(ptr))
 #define GET_DWORD(ptr) (*(const DWORD *)(ptr))
 
-#define USUD_LOCALALLOC        0x0001
-#define USUD_LOCALFREE         0x0002
-#define USUD_LOCALCOMPACT      0x0003
-#define USUD_LOCALHEAP         0x0004
-#define USUD_FIRSTCLASS        0x0005
-
-struct tagCURSORICONINFO;
-
 /* internal messages codes */
 enum wine_internal_message
 {
@@ -65,9 +56,7 @@ enum wine_internal_message
     WM_WINE_MOUSE_LL_HOOK
 };
 
-/* internal SendInput codes (FIXME) */
-#define WINE_INTERNAL_INPUT_MOUSE    (16+INPUT_MOUSE)
-#define WINE_INTERNAL_INPUT_KEYBOARD (16+INPUT_KEYBOARD)
+struct tagCURSORICONINFO;
 
 typedef struct tagUSER_DRIVER {
     /* keyboard functions */
@@ -128,37 +117,19 @@ typedef struct tagUSER_DRIVER {
 extern USER_DRIVER USER_Driver;
 
 extern HMODULE user32_module;
-
-/* user lock */
-extern void USER_Lock(void);
-extern void USER_Unlock(void);
-extern void USER_CheckNotLock(void);
-
-extern BOOL USER_IsExitingThread( DWORD tid );
-
-/* hook.c */
-extern LRESULT HOOK_CallHooks( INT id, INT code, WPARAM wparam, LPARAM lparam, BOOL unicode );
-extern BOOL HOOK_IsHooked( INT id );
-
-/* input.c */
 extern BYTE InputKeyStateTable[256];
 extern BYTE AsyncKeyStateTable[256];
+extern DWORD USER16_AlertableWait;
 
-/* syscolor.c */
+extern BOOL CLIPBOARD_ReleaseOwner(void);
+extern BOOL FOCUS_MouseActivate( HWND hwnd );
+extern BOOL HOOK_IsHooked( INT id );
 extern void SYSCOLOR_Init(void);
 extern HPEN SYSCOLOR_GetPen( INT index );
-
-/* sysmetrics.c */
 extern void SYSMETRICS_Init(void);
 extern INT SYSMETRICS_Set( INT index, INT value );
-
-/* sysparams.c */
-extern void SYSPARAMS_GetDoubleClickSize( INT *width, INT *height );
-extern INT SYSPARAMS_GetMouseButtonSwap( void );
-
-extern BOOL CLIPBOARD_ReleaseOwner(void);
-
-extern DWORD USER16_AlertableWait;
+extern void USER_CheckNotLock(void);
+extern BOOL USER_IsExitingThread( DWORD tid );
 
 /* HANDLE16 <-> HANDLE conversions */
 #define HCURSOR_16(h32)    (LOWORD(h32))
@@ -170,4 +141,4 @@ extern DWORD USER16_AlertableWait;
 #define HINSTANCE_32(h16)  ((HINSTANCE)(ULONG_PTR)(h16))
 #define HMODULE_32(h16)    ((HMODULE)(ULONG_PTR)(h16))
 
-#endif  /* __WINE_USER_H */
+#endif /* __WINE_USER_PRIVATE_H */

dlls/user/wnd16.c

@@ -20,7 +20,7 @@
 
 #include "wine/winuser16.h"
 #include "wownt32.h"
-#include "user.h"
+#include "user_private.h"
 #include "win.h"
 #include "winproc.h"
 #include "stackframe.h"

dlls/x11drv/x11drv.h

@@ -40,7 +40,6 @@ typedef int Status;
 
 #include "windef.h"
 #include "winbase.h"
-#include "user.h"
 #include "win.h"
 #include "ddrawi.h"
 #include "thread.h"

dlls/x11drv/x11drv_main.c

@@ -59,7 +59,6 @@
 #include "wine/winbase16.h"
 #include "winreg.h"
 
-#include "user.h"
 #include "win.h"
 #include "x11drv.h"
 #include "xvidmode.h"

include/win.h

@@ -28,8 +28,6 @@
 #include <winuser.h>
 #include <wine/windef16.h>
 
-#include <user.h>
-
 #define WND_MAGIC     0x444e4957  /* 'WIND' */
 
 struct tagCLASS;
@@ -68,14 +66,6 @@ typedef struct tagWND
     DWORD          wExtra[1];     /* Window extra bytes */
 } WND;
 
-typedef struct
-{
-    RECT16	   rectNormal;
-    POINT16	   ptIconPos;
-    POINT16	   ptMaxPos;
-    HWND           hwndIconTitle;
-} INTERNALPOS, *LPINTERNALPOS;
-
   /* WND flags values */
 #define WIN_RESTORE_MAX           0x0001 /* Maximize when restoring */
 #define WIN_NEED_SIZE             0x0002 /* Internal WM_SIZE is needed */
@@ -110,18 +100,20 @@ extern HWND *WIN_ListChildren( HWND hwnd );
 extern BOOL WIN_InternalShowOwnedPopups( HWND owner, BOOL fShow, BOOL unmanagedOnly );
 extern void MDI_CalcDefaultChildPos( HWND hwndClient, INT total, LPPOINT lpPos, INT delta );
 
+/* internal SendInput codes (FIXME) */
+#define WINE_INTERNAL_INPUT_MOUSE    (16+INPUT_MOUSE)
+#define WINE_INTERNAL_INPUT_KEYBOARD (16+INPUT_KEYBOARD)
+
+/* user lock */
+extern void USER_Lock(void);
+extern void USER_Unlock(void);
+
 inline static HWND WIN_GetFullHandle( HWND hwnd )
 {
     if (!HIWORD(hwnd) && hwnd) hwnd = WIN_Handle32( LOWORD(hwnd) );
     return hwnd;
 }
 
-inline static WND *WIN_FindWndPtr16( HWND16 hwnd )
-{
-    /* don't bother with full conversion */
-    return WIN_FindWndPtr( (HWND)(ULONG_PTR)hwnd );
-}
-
 /* to release pointers retrieved by WIN_GetPtr; do not confuse with WIN_ReleaseWndPtr!! */
 inline static void WIN_ReleasePtr( WND *ptr )
 {
@@ -130,16 +122,6 @@ inline static void WIN_ReleasePtr( WND *ptr )
 
 #define WND_OTHER_PROCESS ((WND *)1)  /* returned by WIN_GetPtr on unknown window handles */
 
-extern HBRUSH DEFWND_ControlColor( HDC hDC, UINT ctlType );  /* windows/defwnd.c */
-
-extern BOOL FOCUS_MouseActivate( HWND hwnd );
-
-extern BOOL MENU_SetMenu(HWND, HMENU);
-
-/* check if hwnd is a broadcast magic handle */
-inline static BOOL is_broadcast( HWND hwnd )
-{
-    return (hwnd == HWND_BROADCAST || hwnd == HWND_TOPMOST);
-}
+extern LRESULT HOOK_CallHooks( INT id, INT code, WPARAM wparam, LPARAM lparam, BOOL unicode );
 
 #endif  /* __WINE_WIN_H */

windows/class.c

@@ -34,7 +34,7 @@
 #include "wine/winuser16.h"
 #include "wine/unicode.h"
 #include "win.h"
-#include "user.h"
+#include "user_private.h"
 #include "controls.h"
 #include "dce.h"
 #include "winproc.h"

windows/clipboard.c

@@ -49,7 +49,7 @@
 #include "wine/winuser16.h"
 #include "wine/winbase16.h"
 #include "heap.h"
-#include "user.h"
+#include "user_private.h"
 #include "win.h"
 
 #include "wine/debug.h"

windows/cursoricon.c

@@ -63,7 +63,7 @@
 #include "cursoricon.h"
 #include "module.h"
 #include "wine/debug.h"
-#include "user.h"
+#include "user_private.h"
 #include "message.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(cursor);

windows/dce.c

@@ -34,7 +34,7 @@
 #include <assert.h>
 #include "dce.h"
 #include "win.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/debug.h"
 #include "windef.h"
 #include "wingdi.h"

windows/defwnd.c

@@ -31,7 +31,7 @@
 #include "winnls.h"
 #include "imm.h"
 #include "win.h"
-#include "user.h"
+#include "user_private.h"
 #include "controls.h"
 #include "nonclient.h"
 #include "winpos.h"

windows/dialog.c

@@ -39,7 +39,7 @@
 #include "controls.h"
 #include "win.h"
 #include "winpos.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/debug.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(dialog);

windows/input.c

@@ -42,6 +42,7 @@
 #include "wine/server.h"
 #include "win.h"
 #include "message.h"
+#include "user_private.h"
 #include "winternl.h"
 #include "wine/debug.h"
 #include "winerror.h"

windows/mdi.c

@@ -97,7 +97,7 @@
 #include "nonclient.h"
 #include "controls.h"
 #include "message.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/debug.h"
 #include "dlgs.h"
 

windows/message.c

@@ -41,7 +41,7 @@
 #include "controls.h"
 #include "dde.h"
 #include "message.h"
-#include "user.h"
+#include "user_private.h"
 #include "win.h"
 #include "winpos.h"
 #include "winproc.h"

windows/msgbox.c

@@ -30,7 +30,7 @@
 #include "winreg.h"
 #include "winternl.h"
 #include "dlgs.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/debug.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(dialog);

windows/nonclient.c

@@ -28,7 +28,7 @@
 #include "wine/winuser16.h"
 #include "wownt32.h"
 #include "win.h"
-#include "user.h"
+#include "user_private.h"
 #include "dce.h"
 #include "controls.h"
 #include "cursoricon.h"

windows/queue.c

@@ -33,7 +33,7 @@
 #include "wine/winuser16.h"
 #include "message.h"
 #include "win.h"
-#include "user.h"
+#include "user_private.h"
 #include "thread.h"
 #include "wine/debug.h"
 #include "wine/server.h"

windows/scroll.c

@@ -27,7 +27,7 @@
 #include "wingdi.h"
 #include "wine/winuser16.h"
 #include "winuser.h"
-#include "user.h"
+#include "user_private.h"
 #include "win.h"
 #include "wine/debug.h"
 

windows/spy.c

@@ -30,6 +30,7 @@
 #include "wownt32.h"
 #include "wine/unicode.h"
 #include "win.h"
+#include "user_private.h"
 #include "wine/debug.h"
 #include "message.h"
 #include "winnls.h"

windows/syscolor.c

@@ -33,7 +33,6 @@
 #include "wownt32.h"
 #include "winreg.h"
 #include "local.h"
-#include "user.h"
 #include "gdi.h" /* sic */
 #include "wine/debug.h"
 
@@ -157,7 +156,7 @@ void SYSCOLOR_Init(void)
       if (!bNoReg)
       {
 	DWORD dwDataSize = sizeof(buffer);
-	if (!(RegQueryValueExA(hKey,(LPSTR)DefSysColors[i*2], 0, 0, buffer, &dwDataSize)))
+	if (!(RegQueryValueExA(hKey,DefSysColors[i*2], 0, 0, buffer, &dwDataSize)))
 	  if (sscanf( buffer, "%d %d %d", &r, &g, &b ) == 3)
 	    bOk = TRUE;
       }

windows/sysmetrics.c

@@ -29,7 +29,7 @@
 #include "wingdi.h"
 #include "winuser.h"
 #include "winerror.h"
-#include "user.h"
+#include "user_private.h"
 
 static int sysMetrics[SM_CMETRICS+1];
 static HDC display_dc;

windows/sysparams.c

@@ -33,7 +33,7 @@
 #include "winerror.h"
 
 #include "controls.h"
-#include "user.h"
+#include "user_private.h"
 #include "wine/unicode.h"
 #include "wine/debug.h"
 

windows/user.c

@@ -31,7 +31,7 @@
 #include "winreg.h"
 #include "winternl.h"
 #include "tlhelp32.h"
-#include "user.h"
+#include "user_private.h"
 #include "win.h"
 #include "controls.h"
 #include "cursoricon.h"
@@ -71,6 +71,12 @@ static SYSLEVEL USER_SysLevel = { { &critsect_debug, -1, 0, 0, 0, 0 }, 2 };
 #define USIG_PROCESS_RUNNING      0x0500
 #define USIG_PROCESS_LOADED       0x0600
 
+/* UserSeeUserDo parameters */
+#define USUD_LOCALALLOC        0x0001
+#define USUD_LOCALFREE         0x0002
+#define USUD_LOCALCOMPACT      0x0003
+#define USUD_LOCALHEAP         0x0004
+#define USUD_FIRSTCLASS        0x0005
 
 /***********************************************************************
  *		GetFreeSystemResources (USER.284)

windows/win.c

@@ -33,7 +33,7 @@
 #include "wine/server.h"
 #include "wine/unicode.h"
 #include "win.h"
-#include "user.h"
+#include "user_private.h"
 #include "dce.h"
 #include "controls.h"
 #include "cursoricon.h"

windows/winpos.c

@@ -33,7 +33,7 @@
 #include "wine/winuser16.h"
 #include "wine/server.h"
 #include "controls.h"
-#include "user.h"
+#include "user_private.h"
 #include "win.h"
 #include "message.h"
 #include "winpos.h"
@@ -69,6 +69,14 @@ typedef struct
     WINDOWPOS winPos[1];
 } DWP;
 
+typedef struct
+{
+    RECT16   rectNormal;
+    POINT16  ptIconPos;
+    POINT16  ptMaxPos;
+    HWND     hwndIconTitle;
+} INTERNALPOS, *LPINTERNALPOS;
+
 /* ----- internal variables ----- */
 
 static LPCSTR atomInternalPos;

windows/winproc.c

@@ -37,6 +37,7 @@
 #include "win.h"
 #include "winproc.h"
 #include "message.h"
+#include "user_private.h"
 #include "thread.h"
 #include "dde.h"
 #include "winternl.h"