ole32: Remove an unnecessary special case in StorageBaseImpl_CopyTo.

Opening a storage when it has already been opened now fails with STG_E_ACCESSDENIED. If we attempt to copy a storage to its own child, this will happen during the copy.

ole32: Remove an unnecessary special case in StorageBaseImpl_CopyTo.
6afe24c3 · Vincent Povirk · Alexandre Julliard · 0ad48797 · 6afe24c3
Commit 6afe24c3 authored Dec 13, 2009 by Vincent Povirk Committed by Alexandre Julliard Dec 14, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 10 deletions

storage32.c dlls/ole32/storage32.c +0 -10

No files found.
--- a/dlls/ole32/storage32.c
+++ b/dlls/ole32/storage32.c
@@ -1674,16 +1674,6 @@ static HRESULT WINAPI StorageBaseImpl_CopyTo(
        goto cleanup;

      /*
-       * Check if destination storage is not a child of the source
-       * storage, which will cause an infinite loop
-       */
-      if (pstgChild == pstgDest)
-      {
-        hr = STG_E_ACCESSDENIED;
-        goto cleanup;
-      }
-
-      /*
       * create a new storage in destination storage
       */
      hr = IStorage_CreateStorage( pstgDest, curElement.pwcsName,