Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
6dc30918
Commit
6dc30918
authored
Sep 21, 2005
by
Mike McCormack
Committed by
Alexandre Julliard
Sep 21, 2005
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix some simple memory leaks.
parent
5ea96a85
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
7 additions
and
1 deletion
+7
-1
create.c
dlls/msi/create.c
+3
-1
dialog.c
dlls/msi/dialog.c
+1
-0
format.c
dlls/msi/format.c
+2
-0
helpers.c
dlls/msi/helpers.c
+1
-0
No files found.
dlls/msi/create.c
View file @
6dc30918
...
@@ -64,7 +64,7 @@ static UINT CREATE_execute( struct tagMSIVIEW *view, MSIRECORD *record )
...
@@ -64,7 +64,7 @@ static UINT CREATE_execute( struct tagMSIVIEW *view, MSIRECORD *record )
static
const
WCHAR
szTables
[]
=
{
'_'
,
'T'
,
'a'
,
'b'
,
'l'
,
'e'
,
's'
,
0
};
static
const
WCHAR
szTables
[]
=
{
'_'
,
'T'
,
'a'
,
'b'
,
'l'
,
'e'
,
's'
,
0
};
static
const
WCHAR
szColumns
[]
=
{
'_'
,
'C'
,
'o'
,
'l'
,
'u'
,
'm'
,
'n'
,
's'
,
0
};
static
const
WCHAR
szColumns
[]
=
{
'_'
,
'C'
,
'o'
,
'l'
,
'u'
,
'm'
,
'n'
,
's'
,
0
};
MSIVIEW
*
tv
=
NULL
;
MSIVIEW
*
tv
=
NULL
;
MSIRECORD
*
rec
;
MSIRECORD
*
rec
=
NULL
;
TRACE
(
"%p Table %s (%s)
\n
"
,
cv
,
debugstr_w
(
cv
->
name
),
TRACE
(
"%p Table %s (%s)
\n
"
,
cv
,
debugstr_w
(
cv
->
name
),
cv
->
bIsTemp
?
"temporary"
:
"permanent"
);
cv
->
bIsTemp
?
"temporary"
:
"permanent"
);
...
@@ -148,6 +148,8 @@ static UINT CREATE_execute( struct tagMSIVIEW *view, MSIRECORD *record )
...
@@ -148,6 +148,8 @@ static UINT CREATE_execute( struct tagMSIVIEW *view, MSIRECORD *record )
r
=
ERROR_SUCCESS
;
r
=
ERROR_SUCCESS
;
err:
err:
if
(
rec
)
msiobj_release
(
&
rec
->
hdr
);
/* FIXME: remove values from the string table on error */
/* FIXME: remove values from the string table on error */
if
(
tv
)
if
(
tv
)
tv
->
ops
->
delete
(
tv
);
tv
->
ops
->
delete
(
tv
);
...
...
dlls/msi/dialog.c
View file @
6dc30918
...
@@ -1524,6 +1524,7 @@ static UINT msi_dialog_set_property( msi_dialog *dialog, LPCWSTR event, LPCWSTR
...
@@ -1524,6 +1524,7 @@ static UINT msi_dialog_set_property( msi_dialog *dialog, LPCWSTR event, LPCWSTR
if
(
strcmpW
(
szNullArg
,
arg
)
)
if
(
strcmpW
(
szNullArg
,
arg
)
)
deformat_string
(
dialog
->
package
,
arg
,
&
arg_fmt
);
deformat_string
(
dialog
->
package
,
arg
,
&
arg_fmt
);
MSI_SetPropertyW
(
dialog
->
package
,
prop
,
arg_fmt
);
MSI_SetPropertyW
(
dialog
->
package
,
prop
,
arg_fmt
);
msi_free
(
arg_fmt
);
}
}
else
else
ERR
(
"Badly formatted property string - what happens?
\n
"
);
ERR
(
"Badly formatted property string - what happens?
\n
"
);
...
...
dlls/msi/format.c
View file @
6dc30918
...
@@ -368,6 +368,7 @@ static LPWSTR deformat_group(MSIPACKAGE* package, LPWSTR group, DWORD len,
...
@@ -368,6 +368,7 @@ static LPWSTR deformat_group(MSIPACKAGE* package, LPWSTR group, DWORD len,
}
}
else
else
{
{
msi_free
(
value
);
*
size
=
0
;
*
size
=
0
;
return
NULL
;
return
NULL
;
}
}
...
@@ -423,6 +424,7 @@ static DWORD deformat_string_internal(MSIPACKAGE *package, LPCWSTR ptr,
...
@@ -423,6 +424,7 @@ static DWORD deformat_string_internal(MSIPACKAGE *package, LPCWSTR ptr,
{
{
value
=
deformat_group
(
package
,
key
,
strlenW
(
key
)
+
1
,
record
,
value
=
deformat_group
(
package
,
key
,
strlenW
(
key
)
+
1
,
record
,
&
chunk
);
&
chunk
);
msi_free
(
key
);
key
=
NULL
;
key
=
NULL
;
nested
=
FALSE
;
nested
=
FALSE
;
}
}
...
...
dlls/msi/helpers.c
View file @
6dc30918
...
@@ -488,6 +488,7 @@ void ACTION_free_package_structures( MSIPACKAGE* package)
...
@@ -488,6 +488,7 @@ void ACTION_free_package_structures( MSIPACKAGE* package)
msi_free
(
folder
->
ResolvedTarget
);
msi_free
(
folder
->
ResolvedTarget
);
msi_free
(
folder
->
ResolvedSource
);
msi_free
(
folder
->
ResolvedSource
);
msi_free
(
folder
->
Property
);
msi_free
(
folder
->
Property
);
msi_free
(
folder
);
}
}
LIST_FOR_EACH_SAFE
(
item
,
cursor
,
&
package
->
components
)
LIST_FOR_EACH_SAFE
(
item
,
cursor
,
&
package
->
components
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment