ws2_32: Fix the SO_REUSEADDR tests to work on Win2k3 and newer.

It seems that with Win2k3, the meaning of SO_REUSEADDR got closer to BSD semantics. This is nice, as it allows us to finally work like some version of Windows here.

ws2_32: Fix the SO_REUSEADDR tests to work on Win2k3 and newer.
6f8d1aa8 · Kai Blin · Alexandre Julliard · 49d30980 · 6f8d1aa8
Commit 6f8d1aa8 authored Sep 10, 2008 by Kai Blin Committed by Alexandre Julliard Sep 10, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

sock.c dlls/ws2_32/tests/sock.c +4 -3

No files found.
--- a/dlls/ws2_32/tests/sock.c
+++ b/dlls/ws2_32/tests/sock.c
@@ -1013,13 +1013,14 @@ static void test_so_reuseaddr(void)
    rc = setsockopt(s2, SOL_SOCKET, SO_REUSEADDR, (char*)&reuse, sizeof(reuse));
    ok(rc==0, "setsockopt() failed error: %d\n", WSAGetLastError());

-    todo_wine {
+    /* On Win2k3 and above, all SO_REUSEADDR seems to do is to allow binding to
+     * a port immediately after closing another socket on that port, so
+     * basically following the BSD socket semantics here. */
+    closesocket(s1);
    rc = bind(s2, (struct sockaddr*)&saddr, sizeof(saddr));
    ok(rc==0, "bind() failed error: %d\n", WSAGetLastError());
-    }

    closesocket(s2);
-    closesocket(s1);
 }

 /************* Array containing the tests to run **********/