uxtheme: SetPropW returns a BOOL not an HRESULT.

Therefore fix the code to handle SetPropW failing with this in mind. (Found by PreFast.)

uxtheme: SetPropW returns a BOOL not an HRESULT.
739bdaeb · Rob Shearman · Alexandre Julliard · 8a6f1655 · 739bdaeb
Commit 739bdaeb authored Sep 30, 2008 by Rob Shearman Committed by Alexandre Julliard Sep 30, 2008
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 5 deletions

draw.c dlls/uxtheme/draw.c +4 -5

No files found.
--- a/dlls/uxtheme/draw.c
+++ b/dlls/uxtheme/draw.c
@@ -52,19 +52,18 @@ extern ATOM atDialogThemeEnabled;
 HRESULT WINAPI EnableThemeDialogTexture(HWND hwnd, DWORD dwFlags)
 {
    static const WCHAR szTab[] = { 'T','a','b',0 };
-    HRESULT hr;
+    BOOL res;

    TRACE("(%p,0x%08x\n", hwnd, dwFlags);
-    hr = SetPropW (hwnd, (LPCWSTR)MAKEINTATOM(atDialogThemeEnabled), 
+    res = SetPropW (hwnd, (LPCWSTR)MAKEINTATOM(atDialogThemeEnabled), 
        (HANDLE)(dwFlags|0x80000000)); 
        /* 0x80000000 serves as a "flags set" flag */
-    if (FAILED(hr))
-          return hr;
+    if (!res)
+          return HRESULT_FROM_WIN32(GetLastError());
    if (dwFlags & ETDT_USETABTEXTURE)
        return SetWindowTheme (hwnd, NULL, szTab);
    else
        return SetWindowTheme (hwnd, NULL, NULL);
-    return S_OK;
 }

 /***********************************************************************