server: Avoid a potential NULL dereference in startup_info_dump().

info->data may be set to NULL by get_startup_info, without invalidating the object itself. Signed-off-by: Zebediah Figura <zfigura@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

server: Avoid a potential NULL dereference in startup_info_dump().
74dc9aa3 · Zebediah Figura · Alexandre Julliard · 4ee4fffa · 74dc9aa3
Commit 74dc9aa3 authored Sep 01, 2020 by Zebediah Figura Committed by Alexandre Julliard Sep 02, 2020
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

process.c server/process.c +4 -1

No files found.
--- a/server/process.c
+++ b/server/process.c
@@ -749,8 +749,11 @@ static void startup_info_dump( struct object *obj, int verbose )
    struct startup_info *info = (struct startup_info *)obj;
    assert( obj->ops == &startup_info_ops );
-    fprintf( stderr, "Startup info in=%04x out=%04x err=%04x\n",
+    fputs( "Startup info", stderr );
+    if (info->data)
+        fprintf( stderr, " in=%04x out=%04x err=%04x",
                 info->data->hstdin, info->data->hstdout, info->data->hstderr );
+    fputc( '\n', stderr );
 }
 static int startup_info_signaled( struct object *obj, struct wait_queue_entry *entry )