msi: Remove an unnecessary call to SELECT_get_dimensions().

Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Hans Leidekker <hans@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msi: Remove an unnecessary call to SELECT_get_dimensions().
7728acd1 · Zebediah Figura · Alexandre Julliard · 7c28a1db · 7728acd1
Commit 7728acd1 authored Jan 26, 2019 by Zebediah Figura Committed by Alexandre Julliard Jan 28, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 6 deletions

select.c dlls/msi/select.c +2 -6

No files found.
--- a/dlls/msi/select.c
+++ b/dlls/msi/select.c
@@ -233,14 +233,10 @@ static UINT SELECT_get_column_info( struct tagMSIVIEW *view, UINT n, LPCWSTR *na
 static UINT msi_select_update(struct tagMSIVIEW *view, MSIRECORD *rec, UINT row)
 {
    MSISELECTVIEW *sv = (MSISELECTVIEW*)view;
-    UINT r, i, num_columns, col, type, val;
+    UINT r, i, col, type, val;
    LPCWSTR str;

-    r = SELECT_get_dimensions(view, NULL, &num_columns);
-    if (r != ERROR_SUCCESS)
-        return r;
-
-    for (i = 0; i < num_columns; i++)
+    for (i = 0; i < sv->num_cols; i++)
    {
        col = sv->cols[i];