winejoystick: Fix a crash on accessing a CFArray past its end due to an…

winejoystick: Fix a crash on accessing a CFArray past its end due to an off-by-one error in the Mac code.

winejoystick: Fix a crash on accessing a CFArray past its end due to an…
77432ac4 · Ken Thomases · Alexandre Julliard · 40d806dc · 77432ac4
Commit 77432ac4 authored Mar 18, 2015 by Ken Thomases Committed by Alexandre Julliard Mar 19, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

joystick_osx.c dlls/winejoystick.drv/joystick_osx.c +1 -1

No files found.
--- a/dlls/winejoystick.drv/joystick_osx.c
+++ b/dlls/winejoystick.drv/joystick_osx.c
@@ -528,7 +528,7 @@ static BOOL open_joystick(joystick_t* joystick)
    }

    index = joystick - joysticks;
-    if (index > CFArrayGetCount(device_main_elements))
+    if (index >= CFArrayGetCount(device_main_elements))
        return FALSE;

    joystick->element = (IOHIDElementRef)CFArrayGetValueAtIndex(device_main_elements, index);