Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
7b21373b
Commit
7b21373b
authored
Feb 15, 2016
by
Hans Leidekker
Committed by
Alexandre Julliard
Feb 15, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Fix the CHAR column type.
Signed-off-by:
Hans Leidekker
<
hans@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
477b713a
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
8 deletions
+16
-8
sql.y
dlls/msi/sql.y
+1
-1
db.c
dlls/msi/tests/db.c
+15
-7
No files found.
dlls/msi/sql.y
View file @
7b21373b
...
...
@@ -355,7 +355,7 @@ data_type_l:
data_type:
TK_CHAR
{
$$ = MSITYPE_STRING |
1
;
$$ = MSITYPE_STRING |
0x400
;
}
| TK_CHAR TK_LP data_count TK_RP
{
...
...
dlls/msi/tests/db.c
View file @
7b21373b
...
...
@@ -1286,13 +1286,15 @@ static void test_viewgetcolumninfo(void)
r
=
run_query
(
hdb
,
0
,
"CREATE TABLE `Properties` "
"( `Property` CHAR(255), "
" `Value` CHAR(1), "
" `Intvalue` INT, "
" `Integervalue` INTEGER, "
" `Shortvalue` SHORT, "
" `Longvalue` LONG, "
" `Longcharvalue` LONGCHAR "
" PRIMARY KEY `Property`)"
);
" `Value` CHAR(1), "
" `Intvalue` INT, "
" `Integervalue` INTEGER, "
" `Shortvalue` SHORT, "
" `Longvalue` LONG, "
" `Longcharvalue` LONGCHAR, "
" `Charvalue` CHAR, "
" `Localizablevalue` CHAR LOCALIZABLE "
" PRIMARY KEY `Property`)"
);
ok
(
r
==
ERROR_SUCCESS
,
"Failed to create table
\n
"
);
/* check the column types */
...
...
@@ -1306,6 +1308,8 @@ static void test_viewgetcolumninfo(void)
ok
(
check_record
(
rec
,
5
,
"I2"
),
"wrong record type
\n
"
);
ok
(
check_record
(
rec
,
6
,
"I4"
),
"wrong record type
\n
"
);
ok
(
check_record
(
rec
,
7
,
"S0"
),
"wrong record type
\n
"
);
ok
(
check_record
(
rec
,
8
,
"S0"
),
"wrong record type
\n
"
);
ok
(
check_record
(
rec
,
9
,
"L0"
),
"wrong record type
\n
"
);
MsiCloseHandle
(
rec
);
...
...
@@ -1317,6 +1321,8 @@ static void test_viewgetcolumninfo(void)
ok
(
0x1502
==
get_columns_table_type
(
hdb
,
"Properties"
,
5
),
"_columns table wrong
\n
"
);
ok
(
0x1104
==
get_columns_table_type
(
hdb
,
"Properties"
,
6
),
"_columns table wrong
\n
"
);
ok
(
0x1d00
==
get_columns_table_type
(
hdb
,
"Properties"
,
7
),
"_columns table wrong
\n
"
);
ok
(
0x1d00
==
get_columns_table_type
(
hdb
,
"Properties"
,
8
),
"_columns table wrong
\n
"
);
ok
(
0x1f00
==
get_columns_table_type
(
hdb
,
"Properties"
,
9
),
"_columns table wrong
\n
"
);
/* now try the names */
rec
=
get_column_info
(
hdb
,
"select * from `Properties`"
,
MSICOLINFO_NAMES
);
...
...
@@ -1329,6 +1335,8 @@ static void test_viewgetcolumninfo(void)
ok
(
check_record
(
rec
,
5
,
"Shortvalue"
),
"wrong record type
\n
"
);
ok
(
check_record
(
rec
,
6
,
"Longvalue"
),
"wrong record type
\n
"
);
ok
(
check_record
(
rec
,
7
,
"Longcharvalue"
),
"wrong record type
\n
"
);
ok
(
check_record
(
rec
,
8
,
"Charvalue"
),
"wrong record type
\n
"
);
ok
(
check_record
(
rec
,
9
,
"Localizablevalue"
),
"wrong record type
\n
"
);
MsiCloseHandle
(
rec
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment