winhttp: Return NULL on failure in alloc_handle.

Signed-off-by: Thomas Faber <thomas.faber@reactos.org> Signed-off-by: Hans Leidekker <hans@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

winhttp: Return NULL on failure in alloc_handle.
87c05c87 · Thomas Faber · Alexandre Julliard · 83413751 · 87c05c87
Commit 87c05c87 authored Jun 26, 2016 by Thomas Faber Committed by Alexandre Julliard Jul 03, 2016
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

handle.c dlls/winhttp/handle.c +4 -2

No files found.
--- a/dlls/winhttp/handle.c
+++ b/dlls/winhttp/handle.c
@@ -89,9 +89,10 @@ void release_object( object_header_t *hdr )
 HINTERNET alloc_handle( object_header_t *hdr )
 {
    object_header_t **p;
-    ULONG_PTR handle = 0, num;
+    ULONG_PTR handle, num;

    list_init( &hdr->children );
+    hdr->handle = NULL;

    EnterCriticalSection( &handle_cs );
    if (!max_handles)
@@ -112,11 +113,12 @@ HINTERNET alloc_handle( object_header_t *hdr )
    if (handles[handle]) ERR("handle isn't free but should be\n");

    handles[handle] = addref_object( hdr );
+    hdr->handle = (HINTERNET)(handle + 1);
    while ((next_handle < max_handles) && handles[next_handle]) next_handle++;

 end:
    LeaveCriticalSection( &handle_cs );
-    return hdr->handle = (HINTERNET)(handle + 1);
+    return hdr->handle;
 }

 BOOL free_handle( HINTERNET hinternet )