mp3dmod: Release a held buffer on destruction.

Signed-off-by: Zebediah Figura <zfigura@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mp3dmod: Release a held buffer on destruction.
88357e92 · Zebediah Figura · Alexandre Julliard · fb94eae9 · 88357e92 · 88357e92
Commit 88357e92 authored Feb 26, 2020 by Zebediah Figura Committed by Alexandre Julliard Feb 26, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

mp3dmod.c dlls/mp3dmod/mp3dmod.c +2 -0

mp3dmod.c dlls/mp3dmod/tests/mp3dmod.c +1 -1

No files found.
--- a/dlls/mp3dmod/mp3dmod.c
+++ b/dlls/mp3dmod/mp3dmod.c
@@ -103,6 +103,8 @@ static ULONG WINAPI Unknown_Release(IUnknown *iface)

    if (!refcount)
    {
+        if (This->buffer)
+            IMediaBuffer_Release(This->buffer);
        if (This->intype_set)
            MoFreeMediaType(&This->intype);
        MoFreeMediaType(&This->outtype);

--- a/dlls/mp3dmod/tests/mp3dmod.c
+++ b/dlls/mp3dmod/tests/mp3dmod.c
@@ -239,7 +239,7 @@ static void test_convert(void)
    ok(hr == S_OK, "got %#x\n", hr);

    IMediaObject_Release(dmo);
-    todo_wine ok(inbuf.refcount == 1, "Got outstanding refcount %d.\n", inbuf.refcount);
+    ok(inbuf.refcount == 1, "Got outstanding refcount %d.\n", inbuf.refcount);
    ok(outbuf.refcount == 1, "Got outstanding refcount %d.\n", outbuf.refcount);
 }