msi: Initialize all members of WINTRUST_DATA.

The pSignatureSettings field was not unitilized so it got a random value from the stack causing a later crash when it was dereferenced in Wintrust (SoftPubloadSignature).

msi: Initialize all members of WINTRUST_DATA.
904bedb3 · Philip K. Gisslow · Alexandre Julliard · 136a576d · 904bedb3
Commit 904bedb3 authored Jan 05, 2023 by Philip K. Gisslow Committed by Alexandre Julliard Jan 06, 2023
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 5 deletions

msi.c dlls/msi/msi.c +2 -5

No files found.
--- a/dlls/msi/msi.c
+++ b/dlls/msi/msi.c
@@ -2544,18 +2544,15 @@ HRESULT WINAPI MsiGetFileSignatureInformationW( const WCHAR *path, DWORD flags, 
    info.hFile          = NULL;
    info.pgKnownSubject = NULL;

+    memset( &data, 0, sizeof(data) );
    data.cbStruct            = sizeof(data);
-    data.pPolicyCallbackData = NULL;
-    data.pSIPClientData      = NULL;
    data.dwUIChoice          = WTD_UI_NONE;
    data.fdwRevocationChecks = WTD_REVOKE_WHOLECHAIN;
    data.dwUnionChoice       = WTD_CHOICE_FILE;
    data.u.pFile             = &info;
    data.dwStateAction       = WTD_STATEACTION_VERIFY;
-    data.hWVTStateData       = NULL;
-    data.pwszURLReference    = NULL;
-    data.dwProvFlags         = 0;
    data.dwUIContext         = WTD_UICONTEXT_INSTALL;
+
    hr = WinVerifyTrustEx( INVALID_HANDLE_VALUE, &generic_verify_v2, &data );
    *cert = NULL;
    if (FAILED(hr)) goto done;