msi: Fix a double free.

TABLE_drop() calls TABLE_remove_column() which calls msi_update_table_columns() which frees column info and possibly returns without reallocating. When that happens it will be freed again when TABLE_drop() finally calls free_table().

msi: Fix a double free.
91ac47b8 · Hans Leidekker · Alexandre Julliard · 182e7514 · 91ac47b8
Commit 91ac47b8 authored Apr 20, 2009 by Hans Leidekker Committed by Alexandre Julliard Apr 20, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

table.c dlls/msi/table.c +2 -1

No files found.
--- a/dlls/msi/table.c
+++ b/dlls/msi/table.c
@@ -1038,8 +1038,9 @@ static void msi_update_table_columns( MSIDATABASE *db, LPCWSTR name )
    table = find_cached_table( db, name );
    old_count = table->col_count;
    msi_free( table->colinfo );
-    table_get_column_info( db, name, &table->colinfo, &table->col_count );
+    table->colinfo = NULL;

+    table_get_column_info( db, name, &table->colinfo, &table->col_count );
    if (!table->col_count)
        return;