activeds: Free memory on error paths (coverity).

992ec949 · Alistair Leslie-Hughes · Alexandre Julliard · 820a9d0d · 992ec949
Commit 992ec949 authored May 08, 2023 by Alistair Leslie-Hughes Committed by Alexandre Julliard May 09, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 1 deletion

pathname.c dlls/activeds/pathname.c +8 -1

No files found.
--- a/dlls/activeds/pathname.c
+++ b/dlls/activeds/pathname.c
@@ -136,7 +136,10 @@ static HRESULT parse_path(BSTR path, BSTR *provider, BSTR *server, BSTR *dn)
    if (!*p) return S_OK;

    if (*p++ != '/' || *p++ != '/' || !*p)
+    {
+        SysFreeString(*provider);
        return E_ADS_BAD_PATHNAME;
+    }

    p_server = p;
    server_len = 0;
@@ -145,7 +148,11 @@ static HRESULT parse_path(BSTR path, BSTR *provider, BSTR *server, BSTR *dn)
        p++;
        server_len++;
    }
-    if (server_len == 0) return E_ADS_BAD_PATHNAME;
+    if (server_len == 0)
+    {
+        SysFreeString(*provider);
+        return E_ADS_BAD_PATHNAME;
+    }

    *server = SysAllocStringLen(p_server, server_len);
    if (!*server)