dwrite: Fix potential strings object leak (Coverity).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dwrite: Fix potential strings object leak (Coverity).
9f1dd9fc · Nikolay Sivov · Alexandre Julliard · e0cad340 · 9f1dd9fc
Commit 9f1dd9fc authored Feb 03, 2020 by Nikolay Sivov Committed by Alexandre Julliard Feb 03, 2020
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 4 deletions

opentype.c dlls/dwrite/opentype.c +3 -4

No files found.
--- a/dlls/dwrite/opentype.c
+++ b/dlls/dwrite/opentype.c
@@ -2166,10 +2166,6 @@ static HRESULT opentype_get_font_strings_from_meta(const struct file_stream_desc

    *ret = NULL;

-    hr = create_localizedstrings(&strings);
-    if (FAILED(hr))
-        return hr;
-
    switch (id)
    {
        case DWRITE_INFORMATIONAL_STRING_DESIGN_SCRIPT_LANGUAGE_TAG:
@@ -2183,6 +2179,9 @@ static HRESULT opentype_get_font_strings_from_meta(const struct file_stream_desc
            return S_OK;
    }

+    if (FAILED(hr = create_localizedstrings(&strings)))
+        return hr;
+
    opentype_get_font_table(stream_desc, MS_META_TAG, &meta);

    if (meta.data)