winecfg: Fix a crash on empty size field in Desktop Integration.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

winecfg: Fix a crash on empty size field in Desktop Integration.
a11b8ded · Nikolay Sivov · Alexandre Julliard · 19cb98aa · a11b8ded
Commit a11b8ded authored Dec 11, 2015 by Nikolay Sivov Committed by Alexandre Julliard Dec 12, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 2 deletions

theme.c programs/winecfg/theme.c +11 -2

No files found.
--- a/programs/winecfg/theme.c
+++ b/programs/winecfg/theme.c
@@ -1214,8 +1214,17 @@ ThemeDlgProc (HWND hDlg, UINT uMsg, WPARAM wParam, LPARAM lParam)
                            int index = SendDlgItemMessageW(hDlg, IDC_SYSPARAM_COMBO, CB_GETCURSEL, 0, 0);

                            index = SendDlgItemMessageW(hDlg, IDC_SYSPARAM_COMBO, CB_GETITEMDATA, index, 0);
-                            metrics[index].size = atoi(text);
-                            HeapFree(GetProcessHeap(), 0, text);
+
+                            if (text)
+                            {
+                                metrics[index].size = atoi(text);
+                                HeapFree(GetProcessHeap(), 0, text);
+                            }
+                            else
+                            {
+                                /* for empty string set to minimum value */
+                                SendDlgItemMessageW(hDlg, IDC_SYSPARAM_SIZE_UD, UDM_GETRANGE32, (WPARAM)&metrics[index].size, 0);
+                            }

                            SendMessageW(GetParent(hDlg), PSM_CHANGED, 0, 0);
                            break;