mshtml: Remove selection and range objects from document list when detaching.

Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mshtml: Remove selection and range objects from document list when detaching.
a124117f · Jacek Caban · Alexandre Julliard · 18e0225a · a124117f · a124117f
Commit a124117f authored Mar 21, 2019 by Jacek Caban Committed by Alexandre Julliard Mar 21, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 4 deletions

selection.c dlls/mshtml/selection.c +3 -2

txtrange.c dlls/mshtml/txtrange.c +3 -2

No files found.
--- a/dlls/mshtml/selection.c
+++ b/dlls/mshtml/selection.c
@@ -364,9 +364,10 @@ HRESULT HTMLSelectionObject_Create(HTMLDocumentNode *doc, nsISelection *nsselect

 void detach_selection(HTMLDocumentNode *This)
 {
-    HTMLSelectionObject *iter;
+    HTMLSelectionObject *iter, *next;

-    LIST_FOR_EACH_ENTRY(iter, &This->selection_list, HTMLSelectionObject, entry) {
+    LIST_FOR_EACH_ENTRY_SAFE(iter, next, &This->selection_list, HTMLSelectionObject, entry) {
        iter->doc = NULL;
+        list_remove(&iter->entry);
    }
 }
--- a/dlls/mshtml/txtrange.c
+++ b/dlls/mshtml/txtrange.c
@@ -1760,9 +1760,10 @@ HRESULT HTMLTxtRange_Create(HTMLDocumentNode *doc, nsIDOMRange *nsrange, IHTMLTx

 void detach_ranges(HTMLDocumentNode *This)
 {
-    HTMLTxtRange *iter;
+    HTMLTxtRange *iter, *next;

-    LIST_FOR_EACH_ENTRY(iter, &This->range_list, HTMLTxtRange, entry) {
+    LIST_FOR_EACH_ENTRY_SAFE(iter, next, &This->range_list, HTMLTxtRange, entry) {
        iter->doc = NULL;
+        list_remove(&iter->entry);
    }
 }