Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
a181e4df
Commit
a181e4df
authored
Jul 07, 2012
by
Marcus Meissner
Committed by
Alexandre Julliard
Jul 09, 2012
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
setupx.dll16: Avoid strcmp() result truncation (Coverity).
parent
aa58bcfe
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
1 deletion
+9
-1
virtcopy.c
dlls/setupx.dll16/virtcopy.c
+9
-1
No files found.
dlls/setupx.dll16/virtcopy.c
View file @
a181e4df
...
...
@@ -591,9 +591,17 @@ static void VCP_UI_RegisterProgressClass(void)
static
RETERR16
VCP_UI_NodeCompare
(
LPVIRTNODE
vn1
,
LPVIRTNODE
vn2
)
{
LPCSTR
file1
,
file2
;
int
ret
;
file1
=
vsmGetStringRawName16
(
vn1
->
vfsSrc
.
vhstrFileName
);
file2
=
vsmGetStringRawName16
(
vn2
->
vfsSrc
.
vhstrFileName
);
return
(
RETERR16
)
strcmp
(
file1
,
file2
);
ret
=
strcmp
(
file1
,
file2
);
/* Looks too complicated, but in optimized strcpy we might get
* a 32bit wide difference and would truncate it to 16 bit, so
* erroneously returning equality. */
if
(
ret
<
0
)
return
-
1
;
if
(
ret
>
0
)
return
1
;
return
0
;
}
static
RETERR16
VCP_UI_CopyStart
(
void
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment