rpcrt4: The lifetime of the binding handle stored in the context

handle is independent of the binding handle used in the call that unmarshaled it, so we should use RpcBindingCopy to make a copy of it and then call RpcBindingFree later to free it.

rpcrt4: The lifetime of the binding handle stored in the context
a4843345 · Robert Shearman · Alexandre Julliard · a4fff73b · a4843345
Commit a4843345 authored Jun 02, 2006 by Robert Shearman Committed by Alexandre Julliard Jun 03, 2006
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

ndr_marshall.c dlls/rpcrt4/ndr_marshall.c +2 -1

No files found.
--- a/dlls/rpcrt4/ndr_marshall.c
+++ b/dlls/rpcrt4/ndr_marshall.c
@@ -4516,6 +4516,7 @@ static UINT ndr_update_context_handle(NDR_CCONTEXT *CContext,
            if (!che)
                return ERROR_INVALID_HANDLE;
            list_remove(&che->entry);
+            RpcBindingFree(&che->handle);
            HeapFree(GetProcessHeap(), 0, che);
            che = NULL;
        }
@@ -4527,7 +4528,7 @@ static UINT ndr_update_context_handle(NDR_CCONTEXT *CContext,
        if (!che)
            return ERROR_NOT_ENOUGH_MEMORY;
        che->magic = NDR_CONTEXT_HANDLE_MAGIC;
-        che->handle = hBinding;
+        RpcBindingCopy(hBinding, &che->handle);
        list_add_tail(&context_handle_list, &che->entry);
        memcpy(&che->wire_data, chi, sizeof *chi);
    }