bcrypt: Use SecureZeroMemory() to zero magic values before free.

The compiler may optimize out the assignment before free and then second free on the bcrypt handle finds magic values in the freed memory.

bcrypt: Use SecureZeroMemory() to zero magic values before free.
a7efc770 · Paul Gofman · Alexandre Julliard · 30398d6f · a7efc770
Commit a7efc770 authored Dec 14, 2022 by Paul Gofman Committed by Alexandre Julliard Dec 15, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

bcrypt_main.c dlls/bcrypt/bcrypt_main.c +1 -1

No files found.
--- a/dlls/bcrypt/bcrypt_main.c
+++ b/dlls/bcrypt/bcrypt_main.c
@@ -397,7 +397,7 @@ NTSTATUS WINAPI BCryptOpenAlgorithmProvider( BCRYPT_ALG_HANDLE *handle, const WC

 static void destroy_object( struct object *obj )
 {
-    obj->magic = 0;
+    SecureZeroMemory( &obj->magic, sizeof(obj->magic) );
    free( obj );
 }