Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
aa58bcfe
Commit
aa58bcfe
authored
Jul 07, 2012
by
Marcus Meissner
Committed by
Alexandre Julliard
Jul 09, 2012
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
krnl386.exe16: Do not truncate the strcmp result (Coverity).
parent
1f1686fd
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
1 deletion
+8
-1
kernel.c
dlls/krnl386.exe16/kernel.c
+8
-1
No files found.
dlls/krnl386.exe16/kernel.c
View file @
aa58bcfe
...
...
@@ -254,7 +254,14 @@ SEGPTR WINAPI KERNEL_AnsiLower16( SEGPTR strOrChar )
*/
INT16
WINAPI
KERNEL_lstrcmp16
(
LPCSTR
str1
,
LPCSTR
str2
)
{
return
(
INT16
)
strcmp
(
str1
,
str2
);
int
ret
=
strcmp
(
str1
,
str2
);
/* Looks too complicated, but in optimized strcpy we might get
* a 32bit wide difference and would truncate it to 16 bit, so
* erroneously returning equality. */
if
(
ret
<
0
)
return
-
1
;
if
(
ret
>
0
)
return
1
;
return
0
;
}
/***********************************************************************
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment