winegstreamer: Check the format GUID, size, and pointer in amt_to_gst_caps().

Some application filters enumerate types without a format block. Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

winegstreamer: Check the format GUID, size, and pointer in amt_to_gst_caps().
ac531be9 · Zebediah Figura · Alexandre Julliard · 0c1d9312 · ac531be9
Commit ac531be9 authored Apr 05, 2020 by Zebediah Figura Committed by Alexandre Julliard Apr 06, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

gstdemux.c dlls/winegstreamer/gstdemux.c +8 -0

No files found.
--- a/dlls/winegstreamer/gstdemux.c
+++ b/dlls/winegstreamer/gstdemux.c
@@ -387,6 +387,10 @@ static GstCaps *amt_to_gst_caps_video(const AM_MEDIA_TYPE *mt)
    unsigned int i;
    GstCaps *caps;

+    if (!IsEqualGUID(&mt->formattype, &FORMAT_VideoInfo)
+            || mt->cbFormat < sizeof(VIDEOINFOHEADER) || !mt->pbFormat)
+        return NULL;
+
    for (i = 0; i < ARRAY_SIZE(format_map); ++i)
    {
        if (IsEqualGUID(&mt->subtype, format_map[i].subtype))
@@ -425,6 +429,10 @@ static GstCaps *amt_to_gst_caps_audio(const AM_MEDIA_TYPE *mt)
    GstAudioFormat format = GST_AUDIO_FORMAT_UNKNOWN;
    GstAudioInfo info;

+    if (!IsEqualGUID(&mt->formattype, &FORMAT_WaveFormatEx)
+            || mt->cbFormat < sizeof(WAVEFORMATEX) || !mt->pbFormat)
+        return NULL;
+
    if (IsEqualGUID(&mt->subtype, &MEDIASUBTYPE_PCM))
        format = gst_audio_format_build_integer(wfx->wBitsPerSample != 8,
                G_LITTLE_ENDIAN, wfx->wBitsPerSample, wfx->wBitsPerSample);