mf/evr: Remove duplicated check in GetStreamSinkCount() (Coverity).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mf/evr: Remove duplicated check in GetStreamSinkCount() (Coverity).
b14ba22a · Nikolay Sivov · Alexandre Julliard · 8eee81b6 · b14ba22a · b14ba22a
Commit b14ba22a authored Sep 16, 2021 by Nikolay Sivov Committed by Alexandre Julliard Sep 16, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 3 deletions

evr.c dlls/mf/evr.c +0 -3

mf.c dlls/mf/tests/mf.c +6 -0

No files found.
--- a/dlls/mf/evr.c
+++ b/dlls/mf/evr.c
@@ -1291,9 +1291,6 @@ static HRESULT WINAPI video_renderer_sink_GetStreamSinkCount(IMFMediaSink *iface

    TRACE("%p, %p.\n", iface, count);

-    if (!count)
-        return E_POINTER;
-
    EnterCriticalSection(&renderer->cs);
    if (renderer->flags & EVR_SHUT_DOWN)
        hr = MF_E_SHUTDOWN;

--- a/dlls/mf/tests/mf.c
+++ b/dlls/mf/tests/mf.c
@@ -4559,6 +4559,12 @@ todo_wine
    hr = IMFMediaSink_Shutdown(sink);
    ok(hr == S_OK, "Unexpected hr %#x.\n", hr);

+    hr = IMFMediaSink_GetStreamSinkCount(sink, NULL);
+    ok(hr == MF_E_SHUTDOWN, "Unexpected hr %#x.\n", hr);
+
+    hr = IMFMediaSink_GetStreamSinkCount(sink, &count);
+    ok(hr == MF_E_SHUTDOWN, "Unexpected hr %#x.\n", hr);
+
    hr = IMFRateSupport_GetSlowestRate(rs, MFRATE_FORWARD, FALSE, &rate);
    ok(hr == MF_E_SHUTDOWN, "Unexpected hr %#x.\n", hr);