Commit b1839561 authored by Mike McCormack's avatar Mike McCormack Committed by Alexandre Julliard

msi: Properties are case sensitive.

parent 95bb9032
......@@ -852,7 +852,7 @@ static UINT msi_prop_makehash( const WCHAR *str )
while( *str )
{
hash ^= tolowerW( *str++ );
hash ^= *str++;
hash *= 53;
hash = (hash<<5) | (hash>>27);
}
......@@ -865,7 +865,7 @@ static msi_property *msi_prop_find( MSIPACKAGE *package, LPCWSTR key )
msi_property *prop;
LIST_FOR_EACH_ENTRY( prop, &package->props[hash], msi_property, entry )
if (!lstrcmpiW( prop->key, key ))
if (!lstrcmpW( prop->key, key ))
return prop;
return NULL;
}
......
......@@ -1354,6 +1354,27 @@ static void test_props(void)
ok( !strcmp(buffer,"xy"), "buffer was not changed\n");
ok( sz == 3, "wrong size returned\n");
r = MsiSetProperty(hpkg, "SourceDir", "foo");
ok( r == ERROR_SUCCESS, "wrong return val\n");
sz = 4;
r = MsiGetProperty(hpkg, "SOURCEDIR", buffer, &sz);
ok( r == ERROR_SUCCESS, "wrong return val\n");
ok( !strcmp(buffer,""), "buffer wrong\n");
ok( sz == 0, "wrong size returned\n");
sz = 4;
r = MsiGetProperty(hpkg, "SOMERANDOMNAME", buffer, &sz);
ok( r == ERROR_SUCCESS, "wrong return val\n");
ok( !strcmp(buffer,""), "buffer wrong\n");
ok( sz == 0, "wrong size returned\n");
sz = 4;
r = MsiGetProperty(hpkg, "SourceDir", buffer, &sz);
ok( r == ERROR_SUCCESS, "wrong return val\n");
ok( !strcmp(buffer,"foo"), "buffer wrong\n");
ok( sz == 3, "wrong size returned\n");
MsiCloseHandle( hpkg );
DeleteFile(msifile);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment