Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
b58c88d1
Commit
b58c88d1
authored
Nov 30, 2022
by
Michael Stefaniuc
Committed by
Alexandre Julliard
Nov 30, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
dmstyle: Move a struct declaration to the file it is used in.
And get rid of the typedef for that struct.
parent
44400613
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
22 deletions
+17
-22
dmstyle_private.h
dlls/dmstyle/dmstyle_private.h
+0
-7
styletrack.c
dlls/dmstyle/styletrack.c
+17
-15
No files found.
dlls/dmstyle/dmstyle_private.h
View file @
b58c88d1
...
@@ -55,13 +55,6 @@ extern HRESULT create_dmstyletrack(REFIID riid, void **ret_iface) DECLSPEC_HIDDE
...
@@ -55,13 +55,6 @@ extern HRESULT create_dmstyletrack(REFIID riid, void **ret_iface) DECLSPEC_HIDDE
/*****************************************************************************
/*****************************************************************************
* Auxiliary definitions
* Auxiliary definitions
*/
*/
typedef
struct
_DMUS_PRIVATE_STYLE_ITEM
{
struct
list
entry
;
/* for listing elements */
DWORD
timestamp
;
IDirectMusicStyle8
*
pObject
;
}
DMUS_PRIVATE_STYLE_ITEM
,
*
LPDMUS_PRIVATE_STYLE_ITEM
;
typedef
struct
_DMUS_PRIVATE_COMMAND
{
typedef
struct
_DMUS_PRIVATE_COMMAND
{
struct
list
entry
;
/* for listing elements */
struct
list
entry
;
/* for listing elements */
DMUS_IO_COMMAND
pCommand
;
DMUS_IO_COMMAND
pCommand
;
...
...
dlls/dmstyle/styletrack.c
View file @
b58c88d1
...
@@ -27,6 +27,12 @@ WINE_DEFAULT_DEBUG_CHANNEL(dmstyle);
...
@@ -27,6 +27,12 @@ WINE_DEFAULT_DEBUG_CHANNEL(dmstyle);
/*****************************************************************************
/*****************************************************************************
* IDirectMusicStyleTrack implementation
* IDirectMusicStyleTrack implementation
*/
*/
struct
style_item
{
struct
list
entry
;
DWORD
timestamp
;
IDirectMusicStyle8
*
dmstyle
;
};
typedef
struct
IDirectMusicStyleTrack
{
typedef
struct
IDirectMusicStyleTrack
{
IDirectMusicTrack8
IDirectMusicTrack8_iface
;
IDirectMusicTrack8
IDirectMusicTrack8_iface
;
struct
dmobject
dmobj
;
/* IPersistStream only */
struct
dmobject
dmobj
;
/* IPersistStream only */
...
@@ -81,14 +87,11 @@ static ULONG WINAPI style_track_Release(IDirectMusicTrack8 *iface)
...
@@ -81,14 +87,11 @@ static ULONG WINAPI style_track_Release(IDirectMusicTrack8 *iface)
TRACE
(
"(%p) ref=%ld
\n
"
,
This
,
ref
);
TRACE
(
"(%p) ref=%ld
\n
"
,
This
,
ref
);
if
(
!
ref
)
{
if
(
!
ref
)
{
struct
list
*
cursor
,
*
cursor2
;
struct
style_item
*
item
,
*
item2
;
DMUS_PRIVATE_STYLE_ITEM
*
item
;
LIST_FOR_EACH_SAFE
(
cursor
,
cursor2
,
&
This
->
Items
)
{
item
=
LIST_ENTRY
(
cursor
,
DMUS_PRIVATE_STYLE_ITEM
,
entry
);
list_remove
(
cursor
);
IDirectMusicStyle8_Release
(
item
->
pObject
);
LIST_FOR_EACH_ENTRY_SAFE
(
item
,
item2
,
&
This
->
Items
,
struct
style_item
,
entry
)
{
list_remove
(
&
item
->
entry
);
IDirectMusicStyle8_Release
(
item
->
dmstyle
);
free
(
item
);
free
(
item
);
}
}
...
@@ -135,7 +138,7 @@ static HRESULT WINAPI style_track_GetParam(IDirectMusicTrack8 *iface, REFGUID ty
...
@@ -135,7 +138,7 @@ static HRESULT WINAPI style_track_GetParam(IDirectMusicTrack8 *iface, REFGUID ty
MUSIC_TIME
time
,
MUSIC_TIME
*
next
,
void
*
param
)
MUSIC_TIME
time
,
MUSIC_TIME
*
next
,
void
*
param
)
{
{
IDirectMusicStyleTrack
*
This
=
impl_from_IDirectMusicTrack8
(
iface
);
IDirectMusicStyleTrack
*
This
=
impl_from_IDirectMusicTrack8
(
iface
);
struct
list
*
item
=
NULL
;
struct
style_item
*
item
;
TRACE
(
"(%p, %s, %ld, %p, %p):
\n
"
,
This
,
debugstr_dmguid
(
type
),
time
,
next
,
param
);
TRACE
(
"(%p, %s, %ld, %p, %p):
\n
"
,
This
,
debugstr_dmguid
(
type
),
time
,
next
,
param
);
...
@@ -143,10 +146,9 @@ static HRESULT WINAPI style_track_GetParam(IDirectMusicTrack8 *iface, REFGUID ty
...
@@ -143,10 +146,9 @@ static HRESULT WINAPI style_track_GetParam(IDirectMusicTrack8 *iface, REFGUID ty
return
E_POINTER
;
return
E_POINTER
;
if
(
IsEqualGUID
(
&
GUID_IDirectMusicStyle
,
type
))
{
if
(
IsEqualGUID
(
&
GUID_IDirectMusicStyle
,
type
))
{
LIST_FOR_EACH
(
item
,
&
This
->
Items
)
{
LIST_FOR_EACH_ENTRY
(
item
,
&
This
->
Items
,
struct
style_item
,
entry
)
{
DMUS_PRIVATE_STYLE_ITEM
*
style
=
LIST_ENTRY
(
item
,
DMUS_PRIVATE_STYLE_ITEM
,
entry
);
IDirectMusicStyle8_AddRef
(
item
->
dmstyle
);
IDirectMusicStyle8_AddRef
(
style
->
pObject
);
*
((
IDirectMusicStyle8
**
)
param
)
=
item
->
dmstyle
;
*
((
IDirectMusicStyle8
**
)
param
)
=
style
->
pObject
;
return
S_OK
;
return
S_OK
;
}
}
...
@@ -304,7 +306,7 @@ static HRESULT parse_style_ref(IDirectMusicStyleTrack *This, IStream *stream, co
...
@@ -304,7 +306,7 @@ static HRESULT parse_style_ref(IDirectMusicStyleTrack *This, IStream *stream, co
{
{
struct
chunk_entry
chunk
=
{.
parent
=
strf
};
struct
chunk_entry
chunk
=
{.
parent
=
strf
};
IDirectMusicObject
*
dmobj
;
IDirectMusicObject
*
dmobj
;
DMUS_PRIVATE_STYLE_ITEM
*
item
;
struct
style_item
*
item
;
HRESULT
hr
;
HRESULT
hr
;
/* First chunk is a timestamp */
/* First chunk is a timestamp */
...
@@ -326,7 +328,7 @@ static HRESULT parse_style_ref(IDirectMusicStyleTrack *This, IStream *stream, co
...
@@ -326,7 +328,7 @@ static HRESULT parse_style_ref(IDirectMusicStyleTrack *This, IStream *stream, co
WARN
(
"Failed to load reference: %#lx
\n
"
,
hr
);
WARN
(
"Failed to load reference: %#lx
\n
"
,
hr
);
goto
error
;
goto
error
;
}
}
hr
=
IDirectMusicObject_QueryInterface
(
dmobj
,
&
IID_IDirectMusicStyle8
,
(
void
**
)
&
item
->
pObject
);
hr
=
IDirectMusicObject_QueryInterface
(
dmobj
,
&
IID_IDirectMusicStyle8
,
(
void
**
)
&
item
->
dmstyle
);
if
(
FAILED
(
hr
))
{
if
(
FAILED
(
hr
))
{
WARN
(
"Reference not an IDirectMusicStyle8
\n
"
);
WARN
(
"Reference not an IDirectMusicStyle8
\n
"
);
IDirectMusicObject_Release
(
dmobj
);
IDirectMusicObject_Release
(
dmobj
);
...
@@ -334,7 +336,7 @@ static HRESULT parse_style_ref(IDirectMusicStyleTrack *This, IStream *stream, co
...
@@ -334,7 +336,7 @@ static HRESULT parse_style_ref(IDirectMusicStyleTrack *This, IStream *stream, co
}
}
list_add_tail
(
&
This
->
Items
,
&
item
->
entry
);
list_add_tail
(
&
This
->
Items
,
&
item
->
entry
);
TRACE
(
"Found reference to style %p with timestamp %lu
\n
"
,
item
->
pObject
,
item
->
timestamp
);
TRACE
(
"Found reference to style %p with timestamp %lu
\n
"
,
item
->
dmstyle
,
item
->
timestamp
);
return
S_OK
;
return
S_OK
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment