winhttp: Fix double free on error path in queue_task (scan-build).

queue_task cannot free the struct because it doesn't know whether the struct contains pointers to other dynamically allocated memory that also needs to be freed (as is the case with struct send_request).

winhttp: Fix double free on error path in queue_task (scan-build).
b6307181 · Alex Henrie · Alexandre Julliard · 2cbaa59a · b6307181
Commit b6307181 authored Jun 07, 2023 by Alex Henrie Committed by Alexandre Julliard Jun 08, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 1 deletion

request.c dlls/winhttp/request.c +0 -1

No files found.
--- a/dlls/winhttp/request.c
+++ b/dlls/winhttp/request.c
@@ -218,7 +218,6 @@ static DWORD queue_task( struct queue *queue, TASK_CALLBACK task, struct task_he
    if (!callback_running)
    {
        release_object( obj );
-        free( task_hdr );
        ERR( "Submiting threadpool callback failed, err %lu.\n", GetLastError() );
        return ERROR_OUTOFMEMORY;
    }