wined3d: Use PBO for read-only staging textures.

Signed-off-by: Andrew Wesie <awesie@gmail.com> Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wined3d: Use PBO for read-only staging textures.
b86716eb · Andrew Wesie · Alexandre Julliard · 2742ce91 · b86716eb
Commit b86716eb authored Sep 30, 2018 by Andrew Wesie Committed by Alexandre Julliard Oct 02, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 5 deletions

texture.c dlls/wined3d/texture.c +9 -5

No files found.
--- a/dlls/wined3d/texture.c
+++ b/dlls/wined3d/texture.c
@@ -46,11 +46,15 @@ struct wined3d_rect_f
 static BOOL wined3d_texture_use_pbo(const struct wined3d_texture *texture, const struct wined3d_gl_info *gl_info)
 {
-    return !(texture->resource.access & WINED3D_RESOURCE_ACCESS_CPU)
+    if (!gl_info->supported[ARB_PIXEL_BUFFER_OBJECT]
-            && texture->resource.usage & WINED3DUSAGE_DYNAMIC
+            || texture->resource.format->conv_byte_count
-            && gl_info->supported[ARB_PIXEL_BUFFER_OBJECT]
+            || (texture->flags & (WINED3D_TEXTURE_PIN_SYSMEM | WINED3D_TEXTURE_COND_NP2_EMULATED)))
-            && !texture->resource.format->conv_byte_count
+        return FALSE;
-            && !(texture->flags & (WINED3D_TEXTURE_PIN_SYSMEM | WINED3D_TEXTURE_COND_NP2_EMULATED));
+    /* Use a PBO for dynamic textures and read-only staging textures. */
+    return (!(texture->resource.access & WINED3D_RESOURCE_ACCESS_CPU)
+                && texture->resource.usage & WINED3DUSAGE_DYNAMIC)
+            || texture->resource.access == (WINED3D_RESOURCE_ACCESS_CPU | WINED3D_RESOURCE_ACCESS_MAP_R);
 }
 static BOOL wined3d_texture_use_immutable_storage(const struct wined3d_texture *texture,