Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
c449da64
Commit
c449da64
authored
Aug 02, 2023
by
Jeff Smith
Committed by
Alexandre Julliard
Aug 08, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
d3dx9_36/tests: Use compare_uint() in compare_float() instead of abs().
The result of abs(INT_MIN) is INT_MIN, which breaks the ulps comparison.
parent
076d0641
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
8 deletions
+16
-8
effect.c
dlls/d3dx9_36/tests/effect.c
+8
-4
math.c
dlls/d3dx9_36/tests/math.c
+8
-4
No files found.
dlls/d3dx9_36/tests/effect.c
View file @
c449da64
...
...
@@ -23,6 +23,13 @@
#include "d3dx9.h"
/* helper functions */
static
BOOL
compare_uint
(
unsigned
int
x
,
unsigned
int
y
,
unsigned
int
max_diff
)
{
unsigned
int
diff
=
x
>
y
?
x
-
y
:
y
-
x
;
return
diff
<=
max_diff
;
}
static
BOOL
compare_float
(
FLOAT
f
,
FLOAT
g
,
UINT
ulps
)
{
INT
x
=
*
(
INT
*
)
&
f
;
...
...
@@ -33,10 +40,7 @@ static BOOL compare_float(FLOAT f, FLOAT g, UINT ulps)
if
(
y
<
0
)
y
=
INT_MIN
-
y
;
if
(
abs
(
x
-
y
)
>
ulps
)
return
FALSE
;
return
TRUE
;
return
compare_uint
(
x
,
y
,
ulps
);
}
static
inline
INT
get_int
(
D3DXPARAMETER_TYPE
type
,
const
void
*
data
)
...
...
dlls/d3dx9_36/tests/math.c
View file @
c449da64
...
...
@@ -24,6 +24,13 @@
#include <math.h>
#include <stdint.h>
static
BOOL
compare_uint
(
unsigned
int
x
,
unsigned
int
y
,
unsigned
int
max_diff
)
{
unsigned
int
diff
=
x
>
y
?
x
-
y
:
y
-
x
;
return
diff
<=
max_diff
;
}
static
BOOL
compare_float
(
float
f
,
float
g
,
unsigned
int
ulps
)
{
int
x
=
*
(
int
*
)
&
f
;
...
...
@@ -34,10 +41,7 @@ static BOOL compare_float(float f, float g, unsigned int ulps)
if
(
y
<
0
)
y
=
INT_MIN
-
y
;
if
(
abs
(
x
-
y
)
>
ulps
)
return
FALSE
;
return
TRUE
;
return
compare_uint
(
x
,
y
,
ulps
);
}
static
BOOL
compare_vec2
(
const
D3DXVECTOR2
*
v1
,
const
D3DXVECTOR2
*
v2
,
unsigned
int
ulps
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment