gameux: Move SysFreeString to success branches (Coverity).

c7355f79 · Marcus Meissner · Alexandre Julliard · b8ef9b56 · c7355f79
Commit c7355f79 authored Sep 02, 2012 by Marcus Meissner Committed by Alexandre Julliard Sep 03, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

gamestatistics.c dlls/gameux/gamestatistics.c +2 -4

No files found.
--- a/dlls/gameux/gamestatistics.c
+++ b/dlls/gameux/gamestatistics.c
@@ -240,10 +240,9 @@ static HRESULT GAMEUX_updateStatisticsFile(struct GAMEUX_STATS *stats)
                    {
                        TRACE("    storing statistic %d: name: %s\n", j, debugstr_w(V_BSTR(&vValue)));
                        hr = IXMLDOMElement_setAttribute(statisticsElement, bstrName, vValue);
+                        SysFreeString(V_BSTR(&vValue));
                    }

-                    SysFreeString(V_BSTR(&vValue));
-
                    if(SUCCEEDED(hr))
                    {
                        V_VT(&vValue) = VT_BSTR;
@@ -256,10 +255,9 @@ static HRESULT GAMEUX_updateStatisticsFile(struct GAMEUX_STATS *stats)
                    {
                        TRACE("    storing statistic %d: name: %s\n", j, debugstr_w(V_BSTR(&vValue)));
                        hr = IXMLDOMElement_setAttribute(statisticsElement, bstrValue, vValue);
+                        SysFreeString(V_BSTR(&vValue));
                    }

-                    SysFreeString(V_BSTR(&vValue));
-
                    if(SUCCEEDED(hr))
                        hr = IXMLDOMNode_appendChild(categoryNode, statisticsNode, &statisticsNode);