Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
c9f5f2c6
Commit
c9f5f2c6
authored
Feb 01, 2008
by
Alistair Leslie-Hughes
Committed by
Alexandre Julliard
Feb 04, 2008
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: Correct createElement return value for an invalid type.
parent
d4a4b12a
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
2 deletions
+5
-2
xmldoc.c
dlls/msxml3/tests/xmldoc.c
+2
-2
xmldoc.c
dlls/msxml3/xmldoc.c
+3
-0
No files found.
dlls/msxml3/tests/xmldoc.c
View file @
c9f5f2c6
...
@@ -270,8 +270,8 @@ static void test_createElement(void)
...
@@ -270,8 +270,8 @@ static void test_createElement(void)
V_I4
(
&
vType
)
=
-
1
;
V_I4
(
&
vType
)
=
-
1
;
V_VT
(
&
vName
)
=
VT_NULL
;
V_VT
(
&
vName
)
=
VT_NULL
;
hr
=
IXMLDocument_createElement
(
doc
,
vType
,
vName
,
&
element
);
hr
=
IXMLDocument_createElement
(
doc
,
vType
,
vName
,
&
element
);
ok
(
hr
==
S_OK
,
"Expected S_OK, got %d
\n
"
,
hr
);
ok
(
hr
==
E_NOTIMPL
,
"Expected S_OK, got %d
\n
"
,
hr
);
ok
(
element
!=
NULL
,
"Expected non-
NULL element
\n
"
);
ok
(
element
==
NULL
,
"Expected
NULL element
\n
"
);
if
(
element
!=
NULL
)
if
(
element
!=
NULL
)
{
{
...
...
dlls/msxml3/xmldoc.c
View file @
c9f5f2c6
...
@@ -453,6 +453,9 @@ static HRESULT WINAPI xmldoc_createElement(IXMLDocument *iface, VARIANT vType,
...
@@ -453,6 +453,9 @@ static HRESULT WINAPI xmldoc_createElement(IXMLDocument *iface, VARIANT vType,
if
(
V_VT
(
&
vType
)
!=
VT_I4
)
if
(
V_VT
(
&
vType
)
!=
VT_I4
)
return
E_INVALIDARG
;
return
E_INVALIDARG
;
if
(
type_msxml_to_libxml
(
V_I4
(
&
vType
))
==
-
1
)
return
E_NOTIMPL
;
node
=
xmlNewNode
(
NULL
,
empty
);
node
=
xmlNewNode
(
NULL
,
empty
);
node
->
type
=
type_msxml_to_libxml
(
V_I4
(
&
vType
));
node
->
type
=
type_msxml_to_libxml
(
V_I4
(
&
vType
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment