dsound: Replace a realloc-or-alloc with a free-then-alloc.

The buffer is to be overwritten anyway, so there's no need to preserve its contents. Also, the old code leaked if the realloc were to fail. All in all, free-then-alloc is simpler.

dsound: Replace a realloc-or-alloc with a free-then-alloc.
ca1d074c · Ken Thomases · Alexandre Julliard · ad1090c2 · ca1d074c
Commit ca1d074c authored Feb 23, 2009 by Ken Thomases Committed by Alexandre Julliard Feb 24, 2009
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 4 deletions

buffer.c dlls/dsound/buffer.c +1 -4

No files found.
--- a/dlls/dsound/buffer.c
+++ b/dlls/dsound/buffer.c
@@ -117,10 +117,7 @@ static HRESULT WINAPI IDirectSoundNotifyImpl_SetNotificationPositions(
        } else if (howmuch > 0) {
 	    /* Make an internal copy of the caller-supplied array.
 	     * Replace the existing copy if one is already present. */
-	    if (This->dsb->notifies)
-		    This->dsb->notifies = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
-			This->dsb->notifies, howmuch * sizeof(DSBPOSITIONNOTIFY));
-	    else
+	    HeapFree(GetProcessHeap(), 0, This->dsb->notifies);
 	    This->dsb->notifies = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
 			howmuch * sizeof(DSBPOSITIONNOTIFY));