user32: Fix a memory allocation strategy.

Otherwise, the function allocates a heap memory when prev_size is enough. What is worse is that it returns the buffer untouched if the prev_size is insufficient. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53703

user32: Fix a memory allocation strategy.
cb0e4f5f · Akihiro Sagawa · Alexandre Julliard · 548a6afc · cb0e4f5f
Commit cb0e4f5f authored Sep 19, 2022 by Akihiro Sagawa Committed by Alexandre Julliard Sep 19, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

winproc.c dlls/user32/winproc.c +2 -1

No files found.
--- a/dlls/user32/winproc.c
+++ b/dlls/user32/winproc.c
@@ -747,7 +747,8 @@ void dispatch_win_proc_params( struct win_proc_params *params )
 /* make sure that there is space for 'size' bytes in buffer, growing it if needed */
 static inline void *get_buffer_space( void **buffer, size_t size, size_t prev_size )
 {
-    if (prev_size > size && !(*buffer = HeapAlloc( GetProcessHeap(), 0, size ))) return NULL;
+    if (prev_size < size)
+        *buffer = HeapAlloc( GetProcessHeap(), 0, size );
    return *buffer;
 }