dinput: Free the device after a callback (Valgrind).

Signed-off-by: Sven Baars <sven.wine@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dinput: Free the device after a callback (Valgrind).
cf1b9fe2 · Sven Baars · Alexandre Julliard · 2543295a · cf1b9fe2
Commit cf1b9fe2 authored Jan 29, 2019 by Sven Baars Committed by Alexandre Julliard Jan 29, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

dinput_main.c dlls/dinput/dinput_main.c +4 -0

No files found.
--- a/dlls/dinput/dinput_main.c
+++ b/dlls/dinput/dinput_main.c
@@ -1104,10 +1104,12 @@ static HRESULT WINAPI IDirectInput8AImpl_EnumDevicesBySemantics(

        if (lpCallback(&didevis[i], lpdid, callbackFlags, --remain, pvRef) == DIENUM_STOP)
        {
+            IDirectInputDevice_Release(lpdid);
            HeapFree(GetProcessHeap(), 0, didevis);
            HeapFree(GetProcessHeap(), 0, username_w);
            return DI_OK;
        }
+        IDirectInputDevice_Release(lpdid);
    }

    HeapFree(GetProcessHeap(), 0, didevis);
@@ -1130,9 +1132,11 @@ static HRESULT WINAPI IDirectInput8AImpl_EnumDevicesBySemantics(

            if (lpCallback(&didevi, lpdid, callbackFlags, --remain, pvRef) == DIENUM_STOP)
            {
+                IDirectInputDevice_Release(lpdid);
                HeapFree(GetProcessHeap(), 0, username_w);
                return DI_OK;
            }
+            IDirectInputDevice_Release(lpdid);
        }
    }