mshtml: Don't navigate if GetDisplayUri failed.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

mshtml: Don't navigate if GetDisplayUri failed.
d2daec40 · Gabriel Ivăncescu · Alexandre Julliard · e783c358 · d2daec40
Commit d2daec40 authored Aug 23, 2022 by Gabriel Ivăncescu Committed by Alexandre Julliard Aug 23, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

navigate.c dlls/mshtml/navigate.c +4 -2

No files found.
--- a/dlls/mshtml/navigate.c
+++ b/dlls/mshtml/navigate.c
@@ -1677,9 +1677,11 @@ static void handle_extern_mime_navigation(nsChannelBSC *This)
        hres = IUnknown_QueryInterface(doc_obj->webbrowser, &IID_IWebBrowserPriv, (void**)&webbrowser_priv_old);
        if(SUCCEEDED(hres)) {
            V_VT(&uriv) = VT_BSTR;
-            IUri_GetDisplayUri(uri, &V_BSTR(&uriv));
+            V_BSTR(&uriv) = NULL;
+            hres = IUri_GetDisplayUri(uri, &V_BSTR(&uriv));

-            hres = IWebBrowserPriv_NavigateWithBindCtx(webbrowser_priv_old, &uriv, &flags, NULL, NULL, NULL, bind_ctx, NULL);
+            if(hres == S_OK)
+                hres = IWebBrowserPriv_NavigateWithBindCtx(webbrowser_priv_old, &uriv, &flags, NULL, NULL, NULL, bind_ctx, NULL);

            SysFreeString(V_BSTR(&uriv));
            IWebBrowserPriv_Release(webbrowser_priv_old);