jscript: Return ParseProcedureText when compile fails.

This prevents crashes when there is an invalid script inside a tag property. Because ParseProcedureText calls release_bytecode without checking if compile_script failed, "code" is not set, and this leads to a crash when release_bytecode tries to access it. Signed-off-by: Santino Mazza <mazzasantino1206@gmail.com>

jscript: Return ParseProcedureText when compile fails.
d93712fe · Santino Mazza · Alexandre Julliard · a0cac2e0 · d93712fe
Commit d93712fe authored Jul 19, 2022 by Santino Mazza Committed by Alexandre Julliard Jul 20, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

jscript.c dlls/jscript/jscript.c +5 -2

No files found.
--- a/dlls/jscript/jscript.c
+++ b/dlls/jscript/jscript.c
@@ -1197,9 +1197,12 @@ static HRESULT WINAPI JScriptParseProcedure_ParseProcedureText(IActiveScriptPars
    enter_script(This->ctx, &ei);
    hres = compile_script(This->ctx, pstrCode, dwSourceContextCookie, ulStartingLineNumber, pstrFormalParams,
                          pstrDelimiter, FALSE, This->is_encode, item, &code);
-    if(SUCCEEDED(hres))
-        hres = create_source_function(This->ctx, code, &code->global_code, NULL,  &dispex);
+    if(FAILED(hres))
+        return leave_script(This->ctx, hres);
+
+    hres = create_source_function(This->ctx, code, &code->global_code, NULL, &dispex);
    release_bytecode(code);
+
    hres = leave_script(This->ctx, hres);
    if(FAILED(hres))
        return hres;