rpcrt4: Clear an object pointer during unmarshaling, otherwise we

could end up using the previously allocated memory even if it isn't the right size, causing heap corruption.

rpcrt4: Clear an object pointer during unmarshaling, otherwise we
d98b73a1 · Robert Shearman · Alexandre Julliard · 578df90d · d98b73a1
Commit d98b73a1 authored Jun 09, 2006 by Robert Shearman Committed by Alexandre Julliard Jun 09, 2006
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

ndr_marshall.c dlls/rpcrt4/ndr_marshall.c +3 -0

No files found.
--- a/dlls/rpcrt4/ndr_marshall.c
+++ b/dlls/rpcrt4/ndr_marshall.c
@@ -842,7 +842,10 @@ static void PointerUnmarshall(PMIDL_STUB_MESSAGE pStubMsg,
    pointer_id = NDR_LOCAL_UINT32_READ(Buffer);
    TRACE("pointer_id is 0x%08lx\n", pointer_id);
    if (!fMustAlloc && *pPointer)
+    {
        FIXME("free object pointer %p\n", *pPointer);
+        *pPointer = NULL;
+    }
    if (pointer_id)
      pointer_needs_unmarshaling = 1;
    else